File tree Expand file tree Collapse file tree 1 file changed +10
-4
lines changed Expand file tree Collapse file tree 1 file changed +10
-4
lines changed Original file line number Diff line number Diff line change @@ -600,6 +600,7 @@ TraceKit.computeStackTrace = (function computeStackTraceWrapper() {
600
600
// ex.message = qq is not defined
601
601
// ex.fileName = http://...
602
602
// ex.lineNumber = 59
603
+ // ex.columnNumber = 69
603
604
// ex.stack = ...stack trace... (see the example below)
604
605
// ex.name = ReferenceError
605
606
//
@@ -670,14 +671,19 @@ TraceKit.computeStackTrace = (function computeStackTraceWrapper() {
670
671
stack . push ( element ) ;
671
672
}
672
673
673
- if ( stack [ 0 ] && stack [ 0 ] . line && ! stack [ 0 ] . column && reference ) {
674
- stack [ 0 ] . column = findSourceInLine ( reference [ 1 ] , stack [ 0 ] . url , stack [ 0 ] . line ) ;
675
- }
676
-
677
674
if ( ! stack . length ) {
678
675
return null ;
679
676
}
680
677
678
+ if ( stack [ 0 ] . line && ! stack [ 0 ] . column && reference ) {
679
+ stack [ 0 ] . column = findSourceInLine ( reference [ 1 ] , stack [ 0 ] . url , stack [ 0 ] . line ) ;
680
+ } else if ( ! stack [ 0 ] . column && ex . columnNumber ) {
681
+ // FireFox uses this awesome columnNumber property for its top frame
682
+ // Also note, Firefox's column number is 0-based and everything else expects 1-based,
683
+ // so adding 1
684
+ stack [ 0 ] . column = ex . columnNumber + 1 ;
685
+ }
686
+
681
687
return {
682
688
'mode' : 'stack' ,
683
689
'name' : ex . name ,
You can’t perform that action at this time.
0 commit comments