Skip to content

Commit 92fc68d

Browse files
committed
Capture the columnNumber in FireFox
1 parent d7ff0bc commit 92fc68d

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

vendor/TraceKit/tracekit.js

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -600,6 +600,7 @@ TraceKit.computeStackTrace = (function computeStackTraceWrapper() {
600600
// ex.message = qq is not defined
601601
// ex.fileName = http://...
602602
// ex.lineNumber = 59
603+
// ex.columnNumber = 69
603604
// ex.stack = ...stack trace... (see the example below)
604605
// ex.name = ReferenceError
605606
//
@@ -670,14 +671,19 @@ TraceKit.computeStackTrace = (function computeStackTraceWrapper() {
670671
stack.push(element);
671672
}
672673

673-
if (stack[0] && stack[0].line && !stack[0].column && reference) {
674-
stack[0].column = findSourceInLine(reference[1], stack[0].url, stack[0].line);
675-
}
676-
677674
if (!stack.length) {
678675
return null;
679676
}
680677

678+
if (stack[0].line && !stack[0].column && reference) {
679+
stack[0].column = findSourceInLine(reference[1], stack[0].url, stack[0].line);
680+
} else if (!stack[0].column && ex.columnNumber) {
681+
// FireFox uses this awesome columnNumber property for its top frame
682+
// Also note, Firefox's column number is 0-based and everything else expects 1-based,
683+
// so adding 1
684+
stack[0].column = ex.columnNumber + 1;
685+
}
686+
681687
return {
682688
'mode': 'stack',
683689
'name': ex.name,

0 commit comments

Comments
 (0)