Skip to content

Commit 93902d6

Browse files
committed
ref: Dedupe is now optional, Fix integration build
1 parent a4734da commit 93902d6

40 files changed

+317
-168
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ since we removed some methods from the public API and removed some classes from
4444
- [all] feat: Prefix all private methods with `_`
4545
- [all] build: Use terser instead of uglify
4646
- [opentracing] feat: Introduce `@sentry/opentracing` providing functions to attach opentracing data to Sentry Events
47+
- **breaking** [core] ref: `Dedupe` Integration is now optional, it is no longer enabled by default.
4748

4849
## 4.6.4
4950

dangerfile.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,6 @@ export default async () => {
4848

4949
schedule(async () => {
5050
const result = (await promisify(exec)('cd packages/browser; yarn size:check')).stdout;
51-
message(`@sentry/browser gzip'ed minified size: ${result.split('\n')[1]}`);
51+
message(`@sentry/browser bundle gzip'ed minified size: \n${result.split('\n')[2]}\n${result.split('\n')[3]}`);
5252
});
5353
};

packages/browser/src/sdk.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import { BrowserClient, ReportDialogOptions } from './client';
44
import { Breadcrumbs, GlobalHandlers, LinkedErrors, TryCatch, UserAgent } from './integrations';
55

66
export const defaultIntegrations = [
7-
new CoreIntegrations.Dedupe(),
87
new CoreIntegrations.InboundFilters(),
98
new CoreIntegrations.FunctionToString(),
109
new TryCatch(),

packages/browser/test/index.test.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -128,15 +128,6 @@ describe('SentryBrowser', () => {
128128
captureEvent({ message: 'event' });
129129
});
130130

131-
it('should dedupe an event', async () => {
132-
captureMessage('event222');
133-
captureMessage('event222');
134-
135-
await flush(2000);
136-
137-
expect(beforeSend.calledOnce).to.be.true;
138-
});
139-
140131
it('should not dedupe an event on bound client', async () => {
141132
const localBeforeSend = spy();
142133
getCurrentHub().bindClient(

packages/browser/test/integration/common.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@ function initSDK() {
117117
Sentry.init({
118118
dsn: 'https://[email protected]/1',
119119
// debug: true,
120+
integrations: [new SentryIntegration.Dedupe()],
120121
attachStacktrace: true,
121122
transport: DummyTransport,
122123
ignoreErrors: ['ignoreErrorTest'],
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
../../../integrations/build/dedupe.js

packages/browser/test/integration/dedupe.js.map

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/browser/test/integration/frame.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
<title></title>
77
<script src="polyfills/es6-promise-4.2.5.auto.js"></script>
88
<script src="polyfills/whatwg-fetch-3.0.0.js"></script>
9+
<script src="dedupe.js"></script>
910
<script src="common.js"></script>
1011
<script src="../../build/bundle.js"></script>
1112
<script src="init.js"></script>

packages/browser/test/integration/loader-lazy-no.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
<title></title>
77
<script src="polyfills/es6-promise-4.2.5.auto.js"></script>
88
<script src="polyfills/whatwg-fetch-3.0.0.js"></script>
9+
<script src="dedupe.js"></script>
910
<script src="common.js"></script>
1011
<script src="../../src/loader.js" data-lazy="no"></script>
1112
</head>

packages/browser/test/integration/loader-with-no-global-init-lazy-no.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
<title></title>
66
<script src="polyfills/es6-promise-4.2.5.auto.js"></script>
77
<script src="polyfills/whatwg-fetch-3.0.0.js"></script>
8+
<script src="dedupe.js"></script>
89
<script src="common.js"></script>
910
<script src="../../src/loader.js" data-lazy="no"></script>
1011
</head>

0 commit comments

Comments
 (0)