Skip to content

Commit 94b8017

Browse files
committed
fix(v9/astro): Construct parametrized route during runtime
1 parent 0ced0b1 commit 94b8017

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

dev-packages/e2e-tests/test-applications/astro-5/tests/tracing.dynamic.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ test.describe('nested SSR routes (client, server, server request)', () => {
248248

249249
// Server HTTP request transaction
250250
expect(serverHTTPServerRequestTxn).toMatchObject({
251-
transaction: 'GET /api/user/myUsername123.json', // fixme: should be GET /api/user/[userId].json
251+
transaction: 'GET /api/user/[userId].json',
252252
transaction_info: { source: 'route' },
253253
contexts: {
254254
trace: {
@@ -278,13 +278,13 @@ test.describe('nested SSR routes (client, server, server request)', () => {
278278
await page.goto('/catchAll/hell0/whatever-do');
279279

280280
const routeNameMetaContent = await page.locator('meta[name="sentry-route-name"]').getAttribute('content');
281-
expect(routeNameMetaContent).toBe('%2FcatchAll%2F%5Bpath%5D'); // fixme: should be %2FcatchAll%2F%5B...path%5D
281+
expect(routeNameMetaContent).toBe('%2FcatchAll%2F%5B...path%5D');
282282

283283
const clientPageloadTxn = await clientPageloadTxnPromise;
284284
const serverPageRequestTxn = await serverPageRequestTxnPromise;
285285

286286
expect(clientPageloadTxn).toMatchObject({
287-
transaction: '/catchAll/[path]', // fixme: should be /catchAll/[...path]
287+
transaction: '/catchAll/[...path]',
288288
transaction_info: { source: 'route' },
289289
contexts: {
290290
trace: {
@@ -300,7 +300,7 @@ test.describe('nested SSR routes (client, server, server request)', () => {
300300
});
301301

302302
expect(serverPageRequestTxn).toMatchObject({
303-
transaction: 'GET /catchAll/[path]', // fixme: should be GET /catchAll/[...path]
303+
transaction: 'GET /catchAll/[...path]',
304304
transaction_info: { source: 'route' },
305305
contexts: {
306306
trace: {

0 commit comments

Comments
 (0)