review comments 1

Author: aliu39

dev-packages/browser-integration-tests/suites/integrations/featureFlags/constants.ts

@@ -0,0 +1 @@
+export const FLAG_BUFFER_SIZE = 100; // Corresponds to constant in featureFlags.ts, in browser utils.

dev-packages/browser-integration-tests/suites/integrations/featureFlags/featureFlags/basic/test.ts

@@ -4,7 +4,7 @@ import { sentryTest } from '../../../../../utils/fixtures';
 
 import { envelopeRequestParser, shouldSkipFeatureFlagsTest, waitForErrorRequest } from '../../../../../utils/helpers';
 
-const FLAG_BUFFER_SIZE = 100; // Corresponds to constant in featureFlags.ts, in browser utils.
+import { FLAG_BUFFER_SIZE } from '../../constants'
 
 sentryTest('Basic test with eviction, update, and no async tasks', async ({ getLocalTestUrl, page }) => {
   if (shouldSkipFeatureFlagsTest()) {

dev-packages/browser-integration-tests/suites/integrations/featureFlags/launchdarkly/basic/test.ts

@@ -4,7 +4,7 @@ import { sentryTest } from '../../../../../utils/fixtures';
 
 import { envelopeRequestParser, shouldSkipFeatureFlagsTest, waitForErrorRequest } from '../../../../../utils/helpers';
 
-const FLAG_BUFFER_SIZE = 100; // Corresponds to constant in featureFlags.ts, in browser utils.
+import { FLAG_BUFFER_SIZE } from '../../constants'
 
 sentryTest('Basic test with eviction, update, and no async tasks', async ({ getLocalTestUrl, page }) => {
   if (shouldSkipFeatureFlagsTest()) {

dev-packages/browser-integration-tests/suites/integrations/featureFlags/openfeature/basic/test.ts

@@ -4,7 +4,7 @@ import { sentryTest } from '../../../../../utils/fixtures';
 
 import { envelopeRequestParser, shouldSkipFeatureFlagsTest, waitForErrorRequest } from '../../../../../utils/helpers';
 
-const FLAG_BUFFER_SIZE = 100; // Corresponds to constant in featureFlags.ts, in browser utils.
+import { FLAG_BUFFER_SIZE } from '../../constants'
 
 sentryTest('Basic test with eviction, update, and no async tasks', async ({ getLocalTestUrl, page }) => {
   if (shouldSkipFeatureFlagsTest()) {

dev-packages/browser-integration-tests/suites/integrations/featureFlags/openfeature/errorHook/test.ts

@@ -4,7 +4,7 @@ import { sentryTest } from '../../../../../utils/fixtures';
 
 import { envelopeRequestParser, shouldSkipFeatureFlagsTest, waitForErrorRequest } from '../../../../../utils/helpers';
 
-const FLAG_BUFFER_SIZE = 100; // Corresponds to constant in featureFlags.ts, in browser utils.
+import { FLAG_BUFFER_SIZE } from '../../constants'
 
 sentryTest('Flag evaluation error hook', async ({ getLocalTestUrl, page }) => {
   if (shouldSkipFeatureFlagsTest()) {

dev-packages/browser-integration-tests/suites/integrations/featureFlags/statsig/basic/test.ts

@@ -4,7 +4,7 @@ import { sentryTest } from '../../../../../utils/fixtures';
 
 import { envelopeRequestParser, shouldSkipFeatureFlagsTest, waitForErrorRequest } from '../../../../../utils/helpers';
 
-const FLAG_BUFFER_SIZE = 100; // Corresponds to constant in featureFlags.ts, in browser utils.
+import { FLAG_BUFFER_SIZE } from '../../constants'
 
 sentryTest('Basic test with eviction, update, and no async tasks', async ({ getLocalTestUrl, page }) => {
   if (shouldSkipFeatureFlagsTest()) {
@@ -25,10 +25,14 @@ sentryTest('Basic test with eviction, update, and no async tasks', async ({ getL
   await page.evaluate(bufferSize => {
     const client = (window as any).statsigClient;
     for (let i = 1; i <= bufferSize; i++) {
-      client.checkGate(`feat${i}`, false);
+      client.checkGate(`feat${i}`); // values default to false
     }
-    client.checkGate(`feat${bufferSize + 1}`, true); // eviction
-    client.checkGate('feat3', true); // update
+
+    client.setMockGateValue(`feat${bufferSize + 1}`, true);
+    client.checkGate(`feat${bufferSize + 1}`); // eviction
+
+    client.setMockGateValue('feat3', true);
+    client.checkGate('feat3'); // update
   }, FLAG_BUFFER_SIZE);
 
   const reqPromise = waitForErrorRequest(page);

dev-packages/browser-integration-tests/suites/integrations/featureFlags/statsig/init.js

@@ -3,18 +3,23 @@ import * as Sentry from '@sentry/browser';
 class MockStatsigClient {
   constructor() {
     this._gateEvaluationListeners = [];
+    this._mockGateValues = {};
   }
 
   on(event, listener) {
     this._gateEvaluationListeners.push(listener);
   }
 
-  checkGate(name, defaultVal) {
-    // Note the actual StatsigClient.checkGate does not take a defaultVal.
+  checkGate(name) {
+    const value = this._mockGateValues[name] || false;  // unknown features default to false.
     this._gateEvaluationListeners.forEach(listener => {
-      listener({ gate: { name, value: defaultVal } });
+      listener({ gate: { name, value } });
     });
-    return defaultVal;
+    return value;
+  }
+
+  setMockGateValue(name, value) {
+    this._mockGateValues[name] = value;
   }
 }
 

dev-packages/browser-integration-tests/suites/integrations/featureFlags/statsig/withScope/test.ts

@@ -30,18 +30,22 @@ sentryTest('Flag evaluations in forked scopes are stored separately.', async ({
     const errorButton = document.querySelector('#error') as HTMLButtonElement;
     const client = (window as any).statsigClient;
 
-    client.checkGate('shared', true);
+    client.setMockGateValue('shared', true);
+    client.setMockGateValue('main', true);
+
+    client.checkGate('shared');
 
     Sentry.withScope((scope: Scope) => {
-      client.checkGate('forked', true);
-      client.checkGate('shared', false);
+      client.setMockGateValue('forked', true);
+      client.setMockGateValue('shared', false); // override the value in the parent scope.
+
+      client.checkGate('forked');
+      client.checkGate('shared');
       scope.setTag('isForked', true);
-      if (errorButton) {
-        errorButton.click();
-      }
+      errorButton.click();
     });
 
-    client.checkGate('main', true);
+    client.checkGate('main');
     Sentry.getCurrentScope().setTag('isForked', false);
     errorButton.click();
     return true;

dev-packages/browser-integration-tests/suites/integrations/featureFlags/unleash/basic/test.ts

@@ -4,7 +4,7 @@ import { sentryTest } from '../../../../../utils/fixtures';
 
 import { envelopeRequestParser, shouldSkipFeatureFlagsTest, waitForErrorRequest } from '../../../../../utils/helpers';
 
-const FLAG_BUFFER_SIZE = 100; // Corresponds to constant in featureFlags.ts, in browser utils.
+import { FLAG_BUFFER_SIZE } from '../../constants'
 
 sentryTest('Basic test with eviction, update, and no async tasks', async ({ getLocalTestUrl, page }) => {
   if (shouldSkipFeatureFlagsTest()) {

packages/browser/src/integrations/featureFlags/statsig/integration.ts

@@ -11,7 +11,7 @@ import type { FeatureGate, StatsigClient } from './types';
  *
  * @example
  * ```
- * import { StatsigClient } from '';
+ * import { StatsigClient } from '@statsig/js-client';
  * import * as Sentry from '@sentry/browser';
  *
  * const statsigClient = new StatsigClient();