Merge branch 'develop' into timfish/fix/anr-localvariables-with-debugger

Author: timfish

.github/workflows/auto-release.yml

@@ -13,9 +13,16 @@ jobs:
     name: 'Prepare a new version'
 
     steps:
+      - name: Get auth token
+        id: token
+        uses: actions/create-github-app-token@5d869da34e18e7287c1daad50e0b8ea0f506ce69 # v1.11.0
+        with:
+          app-id: ${{ vars.SENTRY_RELEASE_BOT_CLIENT_ID }}
+          private-key: ${{ secrets.SENTRY_RELEASE_BOT_PRIVATE_KEY }}
+
       - uses: actions/checkout@v4
         with:
-          token: ${{ secrets.GH_RELEASE_PAT }}
+          token: ${{ steps.token.outputs.token }}
           fetch-depth: 0
 
       # https://github.com/actions-ecosystem/action-regex-match
@@ -38,7 +45,7 @@ jobs:
         uses: getsentry/action-prepare-release@v1
         if: github.event.pull_request.merged == true && steps.version-regex.outputs.match != '' && steps.get_version.outputs.version != ''
         env:
-          GITHUB_TOKEN: ${{ secrets.GH_RELEASE_PAT }}
+          GITHUB_TOKEN: ${{ steps.token.outputs.token }}
         with:
           version: ${{ steps.get_version.outputs.version }}
           force: false

.github/workflows/canary.yml

@@ -149,6 +149,12 @@ jobs:
         timeout-minutes: 7
         run: yarn ${{ matrix.build-command }}
 
+      - name: Install Playwright
+        uses: ./.github/actions/install-playwright
+        with:
+          browsers: chromium
+          cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
+
       - name: Run E2E test
         working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
         timeout-minutes: 15

.github/workflows/release.yml

@@ -17,14 +17,20 @@ jobs:
     runs-on: ubuntu-20.04
     name: 'Release a new version'
     steps:
+      - name: Get auth token
+        id: token
+        uses: actions/create-github-app-token@5d869da34e18e7287c1daad50e0b8ea0f506ce69 # v1.11.0
+        with:
+          app-id: ${{ vars.SENTRY_RELEASE_BOT_CLIENT_ID }}
+          private-key: ${{ secrets.SENTRY_RELEASE_BOT_PRIVATE_KEY }}
       - uses: actions/checkout@v4
         with:
-          token: ${{ secrets.GH_RELEASE_PAT }}
+          token: ${{ steps.token.outputs.token }}
           fetch-depth: 0
       - name: Prepare release
         uses: getsentry/action-prepare-release@v1
         env:
-          GITHUB_TOKEN: ${{ secrets.GH_RELEASE_PAT }}
+          GITHUB_TOKEN: ${{ steps.token.outputs.token }}
         with:
           version: ${{ github.event.inputs.version }}
           force: ${{ github.event.inputs.force }}

CHANGELOG.md

@@ -10,6 +10,8 @@
 
 - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
 
+Work in this release was contributed by @robinvw1. Thank you for your contribution!
+
 ## 8.43.0
 
 ### Important Changes

dev-packages/e2e-tests/test-applications/nestjs-8/tests/transactions.test.ts

@@ -46,6 +46,10 @@ test('Sends an API route transaction', async ({ baseURL }) => {
     origin: 'auto.http.otel.http',
   });
 
+  expect(transactionEvent.contexts?.response).toEqual({
+    status_code: 200,
+  });
+
   expect(transactionEvent).toEqual(
     expect.objectContaining({
       spans: expect.arrayContaining([

dev-packages/e2e-tests/test-applications/node-express/tests/transactions.test.ts

@@ -46,6 +46,10 @@ test('Sends an API route transaction', async ({ baseURL }) => {
     origin: 'auto.http.otel.http',
   });
 
+  expect(transactionEvent.contexts?.response).toEqual({
+    status_code: 200,
+  });
+
   expect(transactionEvent).toEqual(
     expect.objectContaining({
       transaction: 'GET /test-transaction',

dev-packages/e2e-tests/test-applications/tanstack-router/yarn.lock

@@ -1,12 +1,15 @@
+import { spawnSync } from 'child_process';
+import { join } from 'path';
 import { conditionalTest } from '../../../utils';
-import { cleanupChildProcesses, createRunner } from '../../../utils/runner';
+import { cleanupChildProcesses } from '../../../utils/runner';
 
 afterAll(() => {
   cleanupChildProcesses();
 });
 
 conditionalTest({ min: 18 })('import-in-the-middle', () => {
-  test('onlyIncludeInstrumentedModules', done => {
-    createRunner(__dirname, 'app.mjs').ensureNoErrorOutput().start(done);
+  test('onlyIncludeInstrumentedModules', () => {
+    const result = spawnSync('node', [join(__dirname, 'app.mjs')], { encoding: 'utf-8' });
+    expect(result.stderr).not.toMatch('should be the only hooked modules but we just hooked');
   });
 });

dev-packages/node-integration-tests/suites/esm/import-in-the-middle/test.ts

@@ -19,6 +19,11 @@
   In v9, we will streamline this behavior so that passing `undefined` will result in tracing being disabled, the same as not passing the option at all.
   If you are relying on `undefined` being passed in and having tracing enabled because of this, you should update your config to set e.g. `tracesSampleRate: 0` instead, which will also enable tracing in v9.
 
+- **The `autoSessionTracking` option is deprecated.**
+
+  To enable session tracking, it is recommended to unset `autoSessionTracking` and ensure that either, in browser environments the `browserSessionIntegration` is added, or in server environments the `httpIntegration` is added.
+  To disable session tracking, it is recommended unset `autoSessionTracking` and to remove the `browserSessionIntegration` in browser environments, or in server environments configure the `httpIntegration` with the `trackIncomingRequestsAsSessions` option set to `false`.
+
 ## `@sentry/utils`
 
 - **The `@sentry/utils` package has been deprecated. Import everything from `@sentry/core` instead.**

docs/migration/draft-v9-migration-guide.md

@@ -42,6 +42,7 @@ export function getDefaultIntegrations(options: BrowserOptions = {}): Integratio
     httpContextIntegration(),
   ];
 
+  // eslint-disable-next-line deprecation/deprecation
   if (options.autoSessionTracking !== false) {
     integrations.push(browserSessionIntegration());
   }