Skip to content

Commit 9f04983

Browse files
authored
fix(testing): Fix format of browser configs (#2444)
Some of the formatting changes made in https://github.com/getsentry/sentry-javascript/pull/2437/files#diff-47f8a8c0ffbefeb69466d5cd4ddf7674) to the format of `browsers.js` accidentally got overwritten in https://github.com/getsentry/sentry-javascript/pull/2438/files#diff-47f8a8c0ffbefeb69466d5cd4ddf7674). While this doesn't break the BrowserStack tests themselves, it does break the script which checks if our configs are up to date.
1 parent 47771a1 commit 9f04983

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

packages/browser/test/integration/browsers.js

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
module.exports = {
55
bs_android_4: {
66
base: "BrowserStack",
7-
browser: "Android",
7+
browser: "Android Browser",
88
device: "Samsung Galaxy Note 4",
99
os: "android",
1010
os_version: "4.4",
@@ -13,7 +13,7 @@ module.exports = {
1313
},
1414
bs_android_5: {
1515
base: "BrowserStack",
16-
browser: "Android",
16+
browser: "Android Browser",
1717
device: "Samsung Galaxy S6",
1818
os: "android",
1919
os_version: "5.0",
@@ -22,7 +22,7 @@ module.exports = {
2222
},
2323
bs_android_6: {
2424
base: "BrowserStack",
25-
browser: "Android",
25+
browser: "Android Browser",
2626
device: "Samsung Galaxy Note 4",
2727
os: "android",
2828
os_version: "6.0",
@@ -31,7 +31,7 @@ module.exports = {
3131
},
3232
bs_android_7: {
3333
base: "BrowserStack",
34-
browser: "Android",
34+
browser: "Android Browser",
3535
device: "Samsung Galaxy Note 8",
3636
os: "android",
3737
os_version: "7.1",
@@ -40,7 +40,7 @@ module.exports = {
4040
},
4141
bs_android_8: {
4242
base: "BrowserStack",
43-
browser: "Android",
43+
browser: "Android Browser",
4444
device: "Samsung Galaxy Note 9",
4545
os: "android",
4646
os_version: "8.1",
@@ -49,7 +49,7 @@ module.exports = {
4949
},
5050
bs_android_9: {
5151
base: "BrowserStack",
52-
browser: "Android",
52+
browser: "Android Browser",
5353
device: "Samsung Galaxy Note 10 Plus",
5454
os: "android",
5555
os_version: "9.0",
@@ -58,11 +58,12 @@ module.exports = {
5858
},
5959
bs_android_10: {
6060
base: "BrowserStack",
61-
browser: "Android",
61+
browser: "Android Browser",
6262
device: "Google Pixel 4 XL",
6363
os: "android",
6464
os_version: "10.0",
6565
real_mobile: true,
66+
browser_version: null,
6667
},
6768
bs_ios_12: {
6869
base: "BrowserStack",
@@ -106,6 +107,8 @@ module.exports = {
106107
browser_version: "latest",
107108
os: "OS X",
108109
os_version: "Catalina",
110+
device: null,
111+
real_mobile: null,
109112
},
110113
bs_edge: {
111114
base: "BrowserStack",

0 commit comments

Comments
 (0)