Skip to content

Commit a00226a

Browse files
committed
fix tests hopefully
1 parent fee1d18 commit a00226a

File tree

4 files changed

+14
-15
lines changed

4 files changed

+14
-15
lines changed

dev-packages/e2e-tests/test-applications/react-router-7-framework-custom/tests/errors/errors.server.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ test.describe('server-side errors', () => {
2020
type: 'Error',
2121
value: errorMessage,
2222
mechanism: {
23-
handled: true,
23+
handled: false,
24+
type: 'react-router',
2425
},
2526
},
2627
],
@@ -67,7 +68,8 @@ test.describe('server-side errors', () => {
6768
type: 'Error',
6869
value: errorMessage,
6970
mechanism: {
70-
handled: true,
71+
handled: false,
72+
type: 'react-router',
7173
},
7274
},
7375
],

dev-packages/e2e-tests/test-applications/react-router-7-framework-node-20-18/tests/errors/errors.server.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ test.describe('server-side errors', () => {
2020
type: 'Error',
2121
value: errorMessage,
2222
mechanism: {
23-
handled: true,
23+
handled: false,
24+
type: 'react-router',
2425
},
2526
},
2627
],
@@ -67,7 +68,8 @@ test.describe('server-side errors', () => {
6768
type: 'Error',
6869
value: errorMessage,
6970
mechanism: {
70-
handled: true,
71+
handled: false,
72+
type: 'react-router',
7173
},
7274
},
7375
],

dev-packages/e2e-tests/test-applications/react-router-7-framework/tests/errors/errors.server.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ test.describe('server-side errors', () => {
2020
type: 'Error',
2121
value: errorMessage,
2222
mechanism: {
23-
handled: true,
23+
handled: false,
24+
type: 'react-router',
2425
},
2526
},
2627
],
@@ -67,7 +68,8 @@ test.describe('server-side errors', () => {
6768
type: 'Error',
6869
value: errorMessage,
6970
mechanism: {
70-
handled: true,
71+
handled: false,
72+
type: 'react-router',
7173
},
7274
},
7375
],

packages/react-router/test/server/createSentryHandleError.test.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,16 +28,15 @@ describe('createSentryHandleError', () => {
2828
mockConsoleError.mockClear();
2929
});
3030

31-
// Helper function to create mock args with proper Request structure
3231
const createMockArgs = (aborted: boolean): LoaderFunctionArgs => {
3332
const controller = new AbortController();
3433
if (aborted) {
3534
controller.abort();
3635
}
3736

38-
const request = new Request('http://test.com', {
37+
const request = {
3938
signal: controller.signal,
40-
});
39+
} as Request;
4140

4241
return { request } as LoaderFunctionArgs;
4342
};
@@ -160,23 +159,19 @@ describe('createSentryHandleError', () => {
160159
it('should wait for flushIfServerless to complete', async () => {
161160
const handleError = createSentryHandleError({});
162161

163-
// Create a promise that resolves after 10ms
164162
let resolveFlush: () => void;
165163
const flushPromise = new Promise<void>(resolve => {
166164
resolveFlush = resolve;
167165
});
168166

169-
// Mock flushIfServerless to return our controlled promise
170167
mockFlushIfServerless.mockReturnValueOnce(flushPromise);
171168

172169
const mockArgs = createMockArgs(false);
173170

174171
const startTime = Date.now();
175172

176-
// Start the handleError call
177173
const handleErrorPromise = handleError(mockError, mockArgs);
178174

179-
// Resolve the flush after 10ms
180175
setTimeout(() => resolveFlush(), 10);
181176

182177
await handleErrorPromise;
@@ -190,12 +185,10 @@ describe('createSentryHandleError', () => {
190185
it('should handle flushIfServerless rejection gracefully', async () => {
191186
const handleError = createSentryHandleError({});
192187

193-
// Make flushIfServerless reject
194188
mockFlushIfServerless.mockRejectedValueOnce(new Error('Flush failed'));
195189

196190
const mockArgs = createMockArgs(false);
197191

198-
// This should not throw
199192
await expect(handleError(mockError, mockArgs)).resolves.toBeUndefined();
200193

201194
expect(mockCaptureException).toHaveBeenCalledWith(mockError, { mechanism });

0 commit comments

Comments
 (0)