Skip to content

Commit abeb2e6

Browse files
committed
ref: Throw SentryError if Ember/Vue instances are not provided
1 parent 73a5c00 commit abeb2e6

File tree

4 files changed

+7
-2
lines changed

4 files changed

+7
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## Unreleased
44

55
- [browser] fix: `DOMError` and `DOMException` should be error level events
6+
- [browser] ref: Log error if Ember/Vue instances are not provided
67
- [utils] fix: Dont mutate original input in `decycle` util function
78
- [utils] fix: Skip non-enumerable properties in `decycle` util function
89
- [utils] ref: Update `wrap` method to hide internal Sentry flags

packages/browser/src/integrations/pluggable/ember.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { captureException, captureMessage, getCurrentHub, Scope, withScope } from '@sentry/core';
22
import { Integration, SentryEvent } from '@sentry/types';
3+
import { logger } from '@sentry/utils/logger';
34
import { getGlobalObject } from '@sentry/utils/misc';
45

56
/** JSDoc */
@@ -34,6 +35,7 @@ export class Ember implements Integration {
3435
*/
3536
public setupOnce(): void {
3637
if (!this.Ember) {
38+
logger.error('EmberIntegration is missing an Ember instance');
3739
return;
3840
}
3941

packages/browser/src/integrations/pluggable/vue.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { captureException, getCurrentHub, withScope } from '@sentry/core';
22
import { Integration, SentryEvent } from '@sentry/types';
33
import { isPlainObject, isUndefined } from '@sentry/utils/is';
4+
import { logger } from '@sentry/utils/logger';
45
import { getGlobalObject } from '@sentry/utils/misc';
56

67
/** JSDoc */
@@ -57,6 +58,7 @@ export class Vue implements Integration {
5758
*/
5859
public setupOnce(): void {
5960
if (!this.Vue || !this.Vue.config) {
61+
logger.error('VueIntegration is missing a Vue instance');
6062
return;
6163
}
6264

packages/utils/test/object.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,11 +121,11 @@ describe('decycle()', () => {
121121
circular.bar = circular;
122122
Object.defineProperty(circular, 'baz', {
123123
enumerable: true,
124-
value: circular
124+
value: circular,
125125
});
126126
Object.defineProperty(circular, 'qux', {
127127
enumerable: false,
128-
value: circular
128+
value: circular,
129129
});
130130

131131
const decycled = decycle(circular);

0 commit comments

Comments
 (0)