More de-duplication

Author: timfish

packages/browser/src/profiling/utils.ts

@@ -5,7 +5,7 @@ import type { DebugImage, Envelope, Event, EventEnvelope, Profile, Span, ThreadC
 import {
   browserPerformanceTimeOrigin,
   forEachEnvelopeItem,
-  getFilenameToDebugIdMap,
+  getDebugImagesForResources,
   logger,
   timestampInSeconds,
   uuid4,
@@ -354,21 +354,7 @@ export function applyDebugMetadata(resource_paths: ReadonlyArray<string>): Debug
     return [];
   }
 
-  // Build a map of filename -> debug_id
-  const filenameDebugIdMap = getFilenameToDebugIdMap(stackParser);
-
-  const images: DebugImage[] = [];
-  for (const path of resource_paths) {
-    if (path && filenameDebugIdMap[path]) {
-      images.push({
-        type: 'sourcemap',
-        code_file: path,
-        debug_id: filenameDebugIdMap[path] as string,
-      });
-    }
-  }
-
-  return images;
+  return getDebugImagesForResources(stackParser, resource_paths);
 }
 
 /**

packages/profiling-node/src/utils.ts

@@ -20,7 +20,7 @@ import {
   createEnvelope,
   dsnToString,
   forEachEnvelopeItem,
-  getFilenameToDebugIdMap,
+  getDebugImagesForResources,
   logger,
   uuid4,
 } from '@sentry/utils';
@@ -432,20 +432,5 @@ export function applyDebugMetadata(client: Client, resource_paths: ReadonlyArray
     return [];
   }
 
-  // Build a map of filename -> debug_id.
-  const filenameDebugIdMap = getFilenameToDebugIdMap(options.stackParser);
-
-  const images: DebugImage[] = [];
-
-  for (const resource of resource_paths) {
-    if (resource && filenameDebugIdMap[resource]) {
-      images.push({
-        type: 'sourcemap',
-        code_file: resource,
-        debug_id: filenameDebugIdMap[resource] as string,
-      });
-    }
-  }
-
-  return images;
+  return getDebugImagesForResources(options.stackParser, resource_paths);
 }

packages/utils/src/debug-ids.ts

@@ -1,4 +1,4 @@
-import type { StackFrame, StackParser } from '@sentry/types';
+import type { DebugImage, StackFrame, StackParser } from '@sentry/types';
 import { GLOBAL_OBJ } from './worldwide';
 
 const debugIdStackParserCache = new WeakMap<StackParser, Map<string, StackFrame[]>>();
@@ -45,3 +45,26 @@ export function getFilenameToDebugIdMap(stackParser: StackParser): Record<string
     return acc;
   }, {});
 }
+
+/**
+ * Returns a list of debug images for the given resources.
+ */
+export function getDebugImagesForResources(
+  stackParser: StackParser,
+  resource_paths: ReadonlyArray<string>,
+): DebugImage[] {
+  const filenameDebugIdMap = getFilenameToDebugIdMap(stackParser);
+
+  const images: DebugImage[] = [];
+  for (const path of resource_paths) {
+    if (path && filenameDebugIdMap[path]) {
+      images.push({
+        type: 'sourcemap',
+        code_file: path,
+        debug_id: filenameDebugIdMap[path] as string,
+      });
+    }
+  }
+
+  return images;
+}