review suggestions

Author: s1gr1d

packages/nuxt/src/module.ts

@@ -98,7 +98,13 @@ export default defineNuxtModule<ModuleOptions>({
     });
 
     nuxt.hooks.hook('pages:extend', pages => {
-      pagesDataTemplate.getContents = () => `export default ${JSON.stringify(pages, null, 2)};`;
+      pagesDataTemplate.getContents = () => {
+        const pagesSubset = pages.map(page => ({
+          file: page.file,
+          path: page.path,
+        }));
+        return `export default ${JSON.stringify(pagesSubset, null, 2)};`;
+      };
     });
 
     nuxt.hooks.hook('nitro:init', nitro => {

packages/nuxt/src/runtime/hooks/updateRouteBeforeResponse.ts

@@ -1,4 +1,4 @@
-import { getActiveSpan, getCurrentScope, getRootSpan, logger, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE } from '@sentry/core';
+import { getActiveSpan, getRootSpan, logger, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE } from '@sentry/core';
 import type { H3Event } from 'h3';
 
 /**
@@ -15,16 +15,10 @@ export function updateRouteBeforeResponse(event: H3Event): void {
   // Example: Matched route is "/users/:id" and the event's path is "/users/123",
   if (matchedRoutePath && matchedRoutePath !== event._path) {
     if (matchedRoutePath === '/**') {
-      // todo: support parametrized SSR pageload spans
       // If page is server-side rendered, the whole path gets transformed to `/**` (Example : `/users/123` becomes `/**` instead of `/users/:id`).
-      return; // Skip if the matched route is a catch-all route.
+      return; // Skip if the matched route is a catch-all route (handled in `route-detector.server.ts`)
     }
 
-    const method = event._method || 'GET';
-
-    const parametrizedTransactionName = `${method.toUpperCase()} ${matchedRoutePath}`;
-    getCurrentScope().setTransactionName(parametrizedTransactionName);
-
     const activeSpan = getActiveSpan(); // In development mode, getActiveSpan() is always undefined
     if (!activeSpan) {
       return;
@@ -52,6 +46,6 @@ export function updateRouteBeforeResponse(event: H3Event): void {
       });
     }
 
-    logger.log(`Updated transaction name for parametrized route: ${parametrizedTransactionName}`);
+    logger.log(`Updated transaction name for parametrized route: ${matchedRoutePath}`);
   }
 }

packages/nuxt/src/runtime/plugins/route-detector.server.ts

@@ -1,18 +1,19 @@
 import { getActiveSpan, getRootSpan, logger, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE } from '@sentry/core';
 import { defineNuxtPlugin } from 'nuxt/app';
-import type { NuxtPage } from 'nuxt/schema';
+import type { NuxtPageSubset } from '../utils/route-extraction';
 import { extractParametrizedRouteFromContext } from '../utils/route-extraction';
 
 export default defineNuxtPlugin(nuxtApp => {
   nuxtApp.hooks.hook('app:rendered', async renderContext => {
-    let buildTimePagesData: NuxtPage[] = [];
+    let buildTimePagesData: NuxtPageSubset[];
     try {
       // This is a common Nuxt pattern to import build-time generated data: https://nuxt.com/docs/4.x/api/kit/templates#creating-a-virtual-file-for-runtime-plugin
       // @ts-expect-error This import is dynamically resolved at build time (`addTemplate` in module.ts)
       const { default: importedPagesData } = await import('#build/sentry--nuxt-pages-data.mjs');
       buildTimePagesData = importedPagesData || [];
     } catch (error) {
       buildTimePagesData = [];
+      logger.warn('Failed to import build-time pages data:', error);
     }
 
     const ssrContext = renderContext.ssrContext;
@@ -36,10 +37,7 @@ export default defineNuxtPlugin(nuxtApp => {
         return;
       }
 
-      const method = ssrContext?.event?._method || 'GET';
-      const parametrizedTransactionName = `${method.toUpperCase()} ${routeInfo.parametrizedRoute}`;
-
-      logger.log('Matched parametrized server route:', parametrizedTransactionName);
+      logger.log('Matched parametrized server route:', routeInfo.parametrizedRoute);
 
       rootSpan.setAttributes({
         [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'route',