Skip to content

Commit b154bd6

Browse files
author
Luca Forstner
committed
rm reference in nuxt
1 parent 22d1f96 commit b154bd6

File tree

2 files changed

+1
-63
lines changed

2 files changed

+1
-63
lines changed

packages/nuxt/src/server/sdk.ts

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import type { SentryNuxtServerOptions } from '../common/types';
1818
export function init(options: SentryNuxtServerOptions): Client | undefined {
1919
const sentryOptions = {
2020
...options,
21-
registerEsmLoaderHooks: mergeRegisterEsmLoaderHooks(options),
2221
defaultIntegrations: getNuxtDefaultIntegrations(options),
2322
};
2423

@@ -92,28 +91,6 @@ function getNuxtDefaultIntegrations(options: NodeOptions): Integration[] {
9291
];
9392
}
9493

95-
/**
96-
* Adds /vue/ to the registerEsmLoaderHooks options and merges it with the old values in the array if one is defined.
97-
* If the registerEsmLoaderHooks option is already a boolean, nothing is changed.
98-
*
99-
* Only exported for Testing purposes.
100-
*/
101-
export function mergeRegisterEsmLoaderHooks(
102-
options: SentryNuxtServerOptions,
103-
): SentryNuxtServerOptions['registerEsmLoaderHooks'] {
104-
if (typeof options.registerEsmLoaderHooks === 'object' && options.registerEsmLoaderHooks !== null) {
105-
return {
106-
// eslint-disable-next-line deprecation/deprecation
107-
exclude: Array.isArray(options.registerEsmLoaderHooks.exclude)
108-
? // eslint-disable-next-line deprecation/deprecation
109-
[...options.registerEsmLoaderHooks.exclude, /vue/]
110-
: // eslint-disable-next-line deprecation/deprecation
111-
options.registerEsmLoaderHooks.exclude ?? [/vue/],
112-
};
113-
}
114-
return options.registerEsmLoaderHooks ?? { exclude: [/vue/] };
115-
}
116-
11794
/**
11895
* Flushes pending Sentry events with a 2-second timeout and in a way that cannot create unhandled promise rejections.
11996
*/

packages/nuxt/test/server/sdk.test.ts

Lines changed: 1 addition & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,8 @@ import { Scope } from '@sentry/node';
55
import { getGlobalScope } from '@sentry/node';
66
import { SDK_VERSION } from '@sentry/node';
77
import { beforeEach, describe, expect, it, vi } from 'vitest';
8-
import type { SentryNuxtServerOptions } from '../../src/common/types';
98
import { init } from '../../src/server';
10-
import { clientSourceMapErrorFilter, mergeRegisterEsmLoaderHooks } from '../../src/server/sdk';
9+
import { clientSourceMapErrorFilter } from '../../src/server/sdk';
1110

1211
const nodeInit = vi.spyOn(SentryNode, 'init');
1312

@@ -163,42 +162,4 @@ describe('Nuxt Server SDK', () => {
163162
});
164163
});
165164
});
166-
167-
describe('mergeRegisterEsmLoaderHooks', () => {
168-
it('merges exclude array when registerEsmLoaderHooks is an object with an exclude array', () => {
169-
const options: SentryNuxtServerOptions = {
170-
registerEsmLoaderHooks: { exclude: [/test/] },
171-
};
172-
const result = mergeRegisterEsmLoaderHooks(options);
173-
expect(result).toEqual({ exclude: [/test/, /vue/] });
174-
});
175-
176-
it('sets exclude array when registerEsmLoaderHooks is an object without an exclude array', () => {
177-
const options: SentryNuxtServerOptions = {
178-
registerEsmLoaderHooks: {},
179-
};
180-
const result = mergeRegisterEsmLoaderHooks(options);
181-
expect(result).toEqual({ exclude: [/vue/] });
182-
});
183-
184-
it('returns boolean when registerEsmLoaderHooks is a boolean', () => {
185-
const options1: SentryNuxtServerOptions = {
186-
registerEsmLoaderHooks: true,
187-
};
188-
const result1 = mergeRegisterEsmLoaderHooks(options1);
189-
expect(result1).toBe(true);
190-
191-
const options2: SentryNuxtServerOptions = {
192-
registerEsmLoaderHooks: false,
193-
};
194-
const result2 = mergeRegisterEsmLoaderHooks(options2);
195-
expect(result2).toBe(false);
196-
});
197-
198-
it('sets exclude array when registerEsmLoaderHooks is undefined', () => {
199-
const options: SentryNuxtServerOptions = {};
200-
const result = mergeRegisterEsmLoaderHooks(options);
201-
expect(result).toEqual({ exclude: [/vue/] });
202-
});
203-
});
204165
});

0 commit comments

Comments
 (0)