try/catch finalize

Author: Lms24

packages/remix/scripts/createRelease.js

@@ -38,7 +38,11 @@ async function createRelease(argv, URL_PREFIX, BUILD_PATH) {
     console.warn('[sentry] Failed to upload sourcemaps.');
   }
 
-  await sentry.releases.finalize(release);
+  try {
+    await sentry.releases.finalize(release);
+  } catch (error) {
+    console.warn('[sentry] Failed to finalize release.');
+  }
 
   if (argv.deleteAfterUpload) {
     try {

packages/remix/test/scripts/upload-sourcemaps.test.ts

@@ -114,6 +114,14 @@ describe('createRelease', () => {
 
     expect(finalizeMock).toHaveBeenCalledWith('0.1.2.3.4');
   });
+
+  it('logs an error when finalize fails', async () => {
+    finalizeMock.mockRejectedValue(new Error('Failed to finalize release'));
+
+    await createRelease({}, '~/build/', 'public/build');
+
+    expect(consoleWarnSpy).toHaveBeenCalledWith('[sentry] Failed to finalize release.');
+  });
 });
 
 // To avoid `--isolatedModules` flag as we're not importing