feat: getRequestheaders should handle legacy DSNs

Author: ntindall

packages/core/src/api.ts

@@ -56,6 +56,9 @@ export class API {
     header.push(`sentry_timestamp=${new Date().getTime()}`);
     header.push(`sentry_client=${clientName}/${clientVersion}`);
     header.push(`sentry_key=${dsn.user}`);
+    if (dsn.pass) {
+      header.push(`sentry_secret=${dsn.pass}`);
+    }
     return {
       'Content-Type': 'application/json',
       'X-Sentry-Auth': header.join(', '),

packages/core/test/lib/api.test.ts

@@ -2,6 +2,7 @@ import { API } from '../../src/api';
 import { Dsn } from '../../src/dsn';
 
 const dsnPublic = 'https://[email protected]:1234/subpath/123';
+const legacyDsn = 'https://abc:[email protected]:1234/subpath/123';
 
 describe('API', () => {
   test('getStoreEndpoint', () => {
@@ -18,7 +19,15 @@ describe('API', () => {
         /^Sentry sentry_version=\d, sentry_timestamp=\d+, sentry_client=a\/1\.0, sentry_key=abc$/,
       ),
     });
+
+    expect(new API(legacyDsn).getRequestHeaders('a', '1.0')).toMatchObject({
+      'Content-Type': 'application/json',
+      'X-Sentry-Auth': expect.stringMatching(
+        /^Sentry sentry_version=\d, sentry_timestamp=\d+, sentry_client=a\/1\.0, sentry_key=abc, sentry_secret=123$/,
+      ),
+    });
   });
+
   test('getReportDialogEndpoint', () => {
     expect(new API(dsnPublic).getReportDialogEndpoint({})).toEqual(
       'https://sentry.io:1234/subpath/api/embed/error-page/?dsn=https://[email protected]:1234/subpath/123',