Skip to content

Commit b6f3c7a

Browse files
authored
build: fix missing plugins in dist directory and simplify grunt build (#1327)
1 parent 4533b2c commit b6f3c7a

File tree

1 file changed

+20
-25
lines changed

1 file changed

+20
-25
lines changed

Gruntfile.js

Lines changed: 20 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -85,17 +85,22 @@ module.exports = function(grunt) {
8585
});
8686

8787
var pluginCombinations = combine(plugins);
88-
var pluginConcatFiles = pluginCombinations.reduce(function(dict, comb) {
89-
var key = comb.map(function(plugin) {
90-
return path.basename(plugin, '.js');
91-
});
92-
key.sort();
9388

94-
var dest = path.join('build/', key.join(','), '/raven.js');
95-
dict[dest] = ['src/singleton.js'].concat(comb);
89+
var pluginConcatFiles = pluginCombinations
90+
.filter(function(comb) {
91+
return comb.length > 0;
92+
})
93+
.reduce(function(dict, comb) {
94+
var key = comb.map(function(plugin) {
95+
return path.basename(plugin, '.js');
96+
});
97+
key.sort();
98+
99+
var dest = path.join('build/', key.join(','), '/raven.js');
100+
dict[dest] = ['src/singleton.js'].concat(comb);
96101

97-
return dict;
98-
}, {});
102+
return dict;
103+
}, {});
99104

100105
var browserifyConfig = {
101106
options: {
@@ -302,24 +307,14 @@ module.exports = function(grunt) {
302307

303308
// Build tasks
304309
grunt.registerTask('_prep', ['clean', 'gitinfo', 'version']);
310+
grunt.registerTask('build', ['_prep', 'build.core', 'build.plugins', 'sri:build']);
311+
grunt.registerTask('build.test', ['_prep', 'build.core', 'browserify:test']);
312+
grunt.registerTask('build.core', ['browserify:core']);
305313
grunt.registerTask(
306-
'browserify.core',
307-
['_prep', 'browserify:core'].concat(browserifyPluginTaskNames)
314+
'build.plugins',
315+
browserifyPluginTaskNames.concat('browserify:plugins-combined')
308316
);
309-
grunt.registerTask('browserify.plugins-combined', [
310-
'_prep',
311-
'browserify:plugins-combined'
312-
]);
313-
grunt.registerTask('build', ['build.core', 'build.plugins-combined']);
314-
grunt.registerTask('build.test', ['_prep', 'browserify.core', 'browserify:test']);
315-
grunt.registerTask('build.core', ['browserify.core', 'uglify', 'sri:dist']);
316-
grunt.registerTask('build.plugins-combined', [
317-
'browserify.plugins-combined',
318-
'uglify',
319-
'sri:dist',
320-
'sri:build'
321-
]);
322-
grunt.registerTask('dist', ['build', 'copy:dist']);
317+
grunt.registerTask('dist', ['build', 'uglify', 'copy:dist', 'sri:dist']);
323318
grunt.registerTask('publish', ['build', 's3']);
324319
grunt.registerTask('test:ci', ['config:ci', 'build.test']);
325320
};

0 commit comments

Comments
 (0)