better sentry-specific comments, add guard for window.document

Author: Lms24

packages/browser-utils/src/metrics/web-vitals/getLCP.ts

@@ -14,6 +14,7 @@
  * limitations under the License.
  */
 
+import { WINDOW } from '../../types';
 import { bindReporter } from './lib/bindReporter';
 import { getActivationStart } from './lib/getActivationStart';
 import { getVisibilityWatcher } from './lib/getVisibilityWatcher';
@@ -92,10 +93,12 @@ export const onLCP = (onReport: (metric: LCPMetric) => void, opts: ReportOpts =
         // Wrap in a setTimeout so the callback is run in a separate task
         // to avoid extending the keyboard/click handler to reduce INP impact
         // https://github.com/GoogleChrome/web-vitals/issues/383
-        addEventListener(type, () => whenIdle(stopListening as () => void), {
-          once: true,
-          capture: true,
-        });
+        if (WINDOW.document) {
+          addEventListener(type, () => whenIdle(stopListening as () => void), {
+            once: true,
+            capture: true,
+          });
+        }
       });
 
       onHidden(stopListening);

packages/browser-utils/src/metrics/web-vitals/lib/observe.ts

@@ -16,13 +16,17 @@
 
 interface PerformanceEntryMap {
   event: PerformanceEventTiming[];
-  paint: PerformancePaintTiming[];
   'first-input': PerformanceEventTiming[];
   'layout-shift': LayoutShift[];
   'largest-contentful-paint': LargestContentfulPaint[];
   'long-animation-frame': PerformanceLongAnimationFrameTiming[];
+  paint: PerformancePaintTiming[];
   navigation: PerformanceNavigationTiming[];
   resource: PerformanceResourceTiming[];
+  // Sentry-specific change:
+  // We add longtask as a supported entry type as we use this in
+  // our `instrumentPerformanceObserver` function also observes 'longtask'
+  // entries.
   longtask: PerformanceEntry[];
 }
 

packages/browser-utils/src/metrics/web-vitals/lib/onHidden.ts

@@ -20,6 +20,7 @@ export interface OnHiddenCallback {
   (event: Event): void;
 }
 
+// Sentry-specific change:
 // This function's logic was NOT updated to web-vitals 4.2.4 but we continue
 // to use the web-vitals 3.5.2 due to us having stricter browser support.
 // PR with context that made the changes: https://github.com/GoogleChrome/web-vitals/pull/442/files#r1530492402