feat(nextjs): Directly forward sourcemaps.disable to webpack plugin

Author: Luca Forstner

packages/nextjs/src/config/types.ts

@@ -122,7 +122,7 @@ export type SentryBuildOptions = {
    */
   sourcemaps?: {
     /**
-     * Disable any functionality related to source maps upload.
+     * Disable any functionality related to source maps.
      */
     disable?: boolean;
 

packages/nextjs/src/config/webpackPluginOptions.ts

@@ -51,10 +51,6 @@ export function getWebpackPluginOptions(
     );
   }
 
-  if (sentryBuildOptions.sourcemaps?.disable) {
-    sourcemapUploadAssets = [];
-  }
-
   return {
     authToken: sentryBuildOptions.authToken,
     headers: sentryBuildOptions.headers,
@@ -69,6 +65,7 @@ export function getWebpackPluginOptions(
     silent: sentryBuildOptions.silent,
     url: sentryBuildOptions.sentryUrl,
     sourcemaps: {
+      disable: sentryBuildOptions.sourcemaps?.disable,
       rewriteSources(source) {
         if (source.startsWith('webpack://_N_E/')) {
           return source.replace('webpack://_N_E/', '');

packages/nextjs/test/config/webpack/webpackPluginOptions.test.ts

@@ -173,11 +173,11 @@ describe('getWebpackPluginOptions()', () => {
     });
   });
 
-  it('sets `sourcemaps.assets` to an empty array when `sourcemaps.disable` is true', () => {
+  it('sets `sourcemaps.disable` plugin options to true when `sourcemaps.disable` is true', () => {
     const buildContext = generateBuildContext({ isServer: false });
     const generatedPluginOptions = getWebpackPluginOptions(buildContext, { sourcemaps: { disable: true } }, undefined);
     expect(generatedPluginOptions.sourcemaps).toMatchObject({
-      assets: [],
+      disable: true,
     });
   });