Skip to content

Commit bbfd2a4

Browse files
committed
remove lowercasing for MCP transport name
1 parent b0bf0b9 commit bbfd2a4

File tree

3 files changed

+18
-18
lines changed

3 files changed

+18
-18
lines changed

packages/core/src/integrations/mcp-server/attributeExtraction.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,13 @@ export function getTransportTypes(transport: MCPTransport): { mcpTransport: stri
4848
if (!transport?.constructor) {
4949
return { mcpTransport: 'unknown', networkTransport: 'unknown' };
5050
}
51-
const transportName =
52-
typeof transport.constructor?.name === 'string' ? transport.constructor.name.toLowerCase() : 'unknown';
51+
const transportName = typeof transport.constructor?.name === 'string' ? transport.constructor.name : 'unknown';
5352
let networkTransport = 'unknown';
5453

55-
if (transportName.includes('stdio')) {
54+
const lowerTransportName = transportName.toLowerCase();
55+
if (lowerTransportName.includes('stdio')) {
5656
networkTransport = 'pipe';
57-
} else if (transportName.includes('http') || transportName.includes('sse')) {
57+
} else if (lowerTransportName.includes('http') || lowerTransportName.includes('sse')) {
5858
networkTransport = 'tcp';
5959
}
6060

packages/core/test/lib/integrations/mcp-server/semanticConventions.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ describe('MCP Server Semantic Conventions', () => {
6161
'mcp.session.id': 'test-session-123',
6262
'client.address': '192.168.1.100',
6363
'client.port': 54321,
64-
'mcp.transport': 'streamablehttpservertransport',
64+
'mcp.transport': 'StreamableHTTPServerTransport',
6565
'network.transport': 'tcp',
6666
'network.protocol.version': '2.0',
6767
'mcp.request.argument.location': '"Seattle, WA"',
@@ -93,7 +93,7 @@ describe('MCP Server Semantic Conventions', () => {
9393
'mcp.resource.uri': 'file:///docs/api.md',
9494
'mcp.request.id': 'req-2',
9595
'mcp.session.id': 'test-session-123',
96-
'mcp.transport': 'streamablehttpservertransport',
96+
'mcp.transport': 'StreamableHTTPServerTransport',
9797
'network.transport': 'tcp',
9898
'network.protocol.version': '2.0',
9999
'mcp.request.argument.uri': '"file:///docs/api.md"',
@@ -125,7 +125,7 @@ describe('MCP Server Semantic Conventions', () => {
125125
'mcp.prompt.name': 'analyze-code',
126126
'mcp.request.id': 'req-3',
127127
'mcp.session.id': 'test-session-123',
128-
'mcp.transport': 'streamablehttpservertransport',
128+
'mcp.transport': 'StreamableHTTPServerTransport',
129129
'network.transport': 'tcp',
130130
'network.protocol.version': '2.0',
131131
'mcp.request.argument.name': '"analyze-code"',
@@ -154,7 +154,7 @@ describe('MCP Server Semantic Conventions', () => {
154154
attributes: {
155155
'mcp.method.name': 'notifications/tools/list_changed',
156156
'mcp.session.id': 'test-session-123',
157-
'mcp.transport': 'streamablehttpservertransport',
157+
'mcp.transport': 'StreamableHTTPServerTransport',
158158
'network.transport': 'tcp',
159159
'network.protocol.version': '2.0',
160160
'sentry.op': 'mcp.notification.client_to_server',
@@ -193,7 +193,7 @@ describe('MCP Server Semantic Conventions', () => {
193193
'mcp.request.id': 'req-4',
194194
'mcp.session.id': 'test-session-123',
195195
// Transport attributes
196-
'mcp.transport': 'streamablehttpservertransport',
196+
'mcp.transport': 'StreamableHTTPServerTransport',
197197
'network.transport': 'tcp',
198198
'network.protocol.version': '2.0',
199199
// Sentry-specific
@@ -227,7 +227,7 @@ describe('MCP Server Semantic Conventions', () => {
227227
attributes: {
228228
'mcp.method.name': 'notifications/message',
229229
'mcp.session.id': 'test-session-123',
230-
'mcp.transport': 'streamablehttpservertransport',
230+
'mcp.transport': 'StreamableHTTPServerTransport',
231231
'network.transport': 'tcp',
232232
'network.protocol.version': '2.0',
233233
'mcp.logging.level': 'info',

packages/core/test/lib/integrations/mcp-server/transportInstrumentation.test.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ describe('MCP Server Transport Instrumentation', () => {
216216
'mcp.tool.name': 'process-file',
217217
'mcp.request.id': 'req-stdio-1',
218218
'mcp.session.id': 'stdio-session-456',
219-
'mcp.transport': 'stdioservertransport',
219+
'mcp.transport': 'StdioServerTransport',
220220
'network.transport': 'pipe', // Should be pipe, not tcp
221221
'network.protocol.version': '2.0',
222222
'mcp.request.argument.path': '"/tmp/data.txt"',
@@ -247,7 +247,7 @@ describe('MCP Server Transport Instrumentation', () => {
247247
attributes: expect.objectContaining({
248248
'mcp.method.name': 'notifications/message',
249249
'mcp.session.id': 'stdio-session-456',
250-
'mcp.transport': 'stdioservertransport',
250+
'mcp.transport': 'StdioServerTransport',
251251
'network.transport': 'pipe',
252252
'mcp.logging.level': 'debug',
253253
'mcp.logging.message': 'Processing stdin input',
@@ -288,7 +288,7 @@ describe('MCP Server Transport Instrumentation', () => {
288288
attributes: expect.objectContaining({
289289
'mcp.method.name': 'resources/read',
290290
'mcp.resource.uri': 'https://api.example.com/data',
291-
'mcp.transport': 'sseservertransport',
291+
'mcp.transport': 'SSEServerTransport',
292292
'network.transport': 'tcp',
293293
'mcp.session.id': 'sse-session-789',
294294
}),
@@ -363,7 +363,7 @@ describe('MCP Server Transport Instrumentation', () => {
363363
'mcp.session.id': 'test-session-direct',
364364
'client.address': '127.0.0.1',
365365
'client.port': 8080,
366-
'mcp.transport': 'streamablehttpservertransport',
366+
'mcp.transport': 'StreamableHTTPServerTransport',
367367
'network.transport': 'tcp',
368368
'network.protocol.version': '2.0',
369369
'mcp.request.argument.input': '"test"',
@@ -508,23 +508,23 @@ describe('MCP Server Transport Instrumentation', () => {
508508
const transport = createMockTransport();
509509
const result = getTransportTypes(transport);
510510

511-
expect(result.mcpTransport).toBe('streamablehttpservertransport');
511+
expect(result.mcpTransport).toBe('StreamableHTTPServerTransport');
512512
expect(result.networkTransport).toBe('tcp');
513513
});
514514

515515
it('extracts stdio transport and maps to pipe network', () => {
516516
const transport = createMockStdioTransport();
517517
const result = getTransportTypes(transport);
518518

519-
expect(result.mcpTransport).toBe('stdioservertransport');
519+
expect(result.mcpTransport).toBe('StdioServerTransport');
520520
expect(result.networkTransport).toBe('pipe');
521521
});
522522

523523
it('extracts SSE transport name', () => {
524524
const transport = createMockSseTransport();
525525
const result = getTransportTypes(transport);
526526

527-
expect(result.mcpTransport).toBe('sseservertransport');
527+
expect(result.mcpTransport).toBe('SSEServerTransport');
528528
expect(result.networkTransport).toBe('tcp');
529529
});
530530

@@ -556,7 +556,7 @@ describe('MCP Server Transport Instrumentation', () => {
556556
};
557557
const result = getTransportTypes(transport);
558558

559-
expect(result.mcpTransport).toBe('customtransport');
559+
expect(result.mcpTransport).toBe('CustomTransport');
560560
expect(result.networkTransport).toBe('unknown');
561561
});
562562
});

0 commit comments

Comments
 (0)