PR feedback

Author: mydea

packages/core/src/integrations/requestdata.ts

@@ -84,7 +84,8 @@ const _requestDataIntegration = ((options: RequestDataIntegrationOptions = {}) =
         const ipAddress = request ? request.ip || (request.socket && request.socket.remoteAddress) : undefined;
         const user = request ? request.user : undefined;
 
-        return addNormalizedRequestDataToEvent(event, normalizedRequest, { ipAddress, user }, addRequestDataOptions);
+        addNormalizedRequestDataToEvent(event, normalizedRequest, { ipAddress, user }, addRequestDataOptions);
+        return event;
       }
 
       if (!request) {

packages/utils/src/requestdata.ts

@@ -268,14 +268,15 @@ export function extractRequestData(
 
 /**
  * Add already normalized request data to an event.
+ * This mutates the passed in event.
  */
 export function addNormalizedRequestDataToEvent(
   event: Event,
   req: Request,
   // This is non-standard data that is not part of the regular HTTP request
   additionalData: { ipAddress?: string; user?: Record<string, unknown> },
   options: AddRequestDataToEventOptions,
-): Event {
+): void {
   const include = {
     ...DEFAULT_INCLUDES,
     ...(options && options.include),
@@ -318,8 +319,6 @@ export function addNormalizedRequestDataToEvent(
       };
     }
   }
-
-  return event;
 }
 
 /**