fix(core): Ensure standalone spans are not sent if SDK is disabled

Lms24 · Lms24 · commit c5ce80a1e894 · 2024-10-28T13:18:22.000+01:00
diff --git a/packages/core/src/tracing/sentrySpan.ts b/packages/core/src/tracing/sentrySpan.ts
@@ -429,10 +429,7 @@ function sendSpanEnvelope(envelope: SpanEnvelope): void {
     return;
   }
 
-  const transport = client.getTransport();
-  if (transport) {
-    transport.send(envelope).then(null, reason => {
-      DEBUG_BUILD && logger.error('Error while sending span:', reason);
-    });
-  }
+  // sendEnvelope should not throw
+  // eslint-disable-next-line @typescript-eslint/no-floating-promises
+  client.sendEnvelope(envelope);
 }

Original file line number	Diff line number	Diff line change
`@@ -429,10 +429,7 @@ function sendSpanEnvelope(envelope: SpanEnvelope): void {`
`429`	`429`	`return;`
`430`	`430`	`}`
`431`	`431`
`432`		`- const transport = client.getTransport();`
`433`		`- if (transport) {`
`434`		`- transport.send(envelope).then(null, reason => {`
`435`		`- DEBUG_BUILD && logger.error('Error while sending span:', reason);`
`436`		`- });`
`437`		`- }`
	`432`	`+ // sendEnvelope should not throw`
	`433`	`+ // eslint-disable-next-line @typescript-eslint/no-floating-promises`
	`434`	`+ client.sendEnvelope(envelope);`
`438`	`435`	`}`