avoid inline conditionals

Author: betegon

packages/core/src/integrations/mcp-server/correlation.ts

@@ -90,7 +90,9 @@ export function completeSpanWithResults(transport: MCPTransport, requestId: Requ
  */
 export function cleanupPendingSpansForTransport(transport: MCPTransport): number {
   const spanMap = transportToSpanMap.get(transport);
-  if (!spanMap) return 0;
+  if (!spanMap) {
+    return 0;
+  }
 
   const pendingCount = spanMap.size;
 

packages/core/src/integrations/mcp-server/resultExtraction.ts

@@ -22,13 +22,17 @@ function buildAllContentItemAttributes(content: unknown[]): Record<string, strin
   };
 
   for (const [i, item] of content.entries()) {
-    if (typeof item !== 'object' || item === null) continue;
+    if (typeof item !== 'object' || item === null) {
+      continue;
+    }
 
     const contentItem = item as Record<string, unknown>;
     const prefix = content.length === 1 ? 'mcp.tool.result' : `mcp.tool.result.${i}`;
 
     const safeSet = (key: string, value: unknown): void => {
-      if (typeof value === 'string') attributes[`${prefix}.${key}`] = value;
+      if (typeof value === 'string') {
+        attributes[`${prefix}.${key}`] = value;
+      }
     };
 
     safeSet('content_type', contentItem.type);
@@ -39,7 +43,11 @@ function buildAllContentItemAttributes(content: unknown[]): Record<string, strin
     if (typeof contentItem.text === 'string') {
       const text = contentItem.text;
       const maxLength = 500;
-      attributes[`${prefix}.content`] = text.length > maxLength ? `${text.slice(0, maxLength - 3)}...` : text;
+      if (text.length > maxLength) {
+        attributes[`${prefix}.content`] = `${text.slice(0, maxLength - 3)}...`;
+      } else {
+        attributes[`${prefix}.content`] = text;
+      }
     }
 
     if (typeof contentItem.data === 'string') {
@@ -64,7 +72,9 @@ function buildAllContentItemAttributes(content: unknown[]): Record<string, strin
  */
 export function extractToolResultAttributes(result: unknown): Record<string, string | number | boolean> {
   let attributes: Record<string, string | number | boolean> = {};
-  if (typeof result !== 'object' || result === null) return attributes;
+  if (typeof result !== 'object' || result === null) {
+    return attributes;
+  }
 
   const resultObj = result as Record<string, unknown>;
   if (typeof resultObj.isError === 'boolean') {
@@ -83,19 +93,24 @@ export function extractToolResultAttributes(result: unknown): Record<string, str
  */
 export function extractPromptResultAttributes(result: unknown): Record<string, string | number | boolean> {
   const attributes: Record<string, string | number | boolean> = {};
-  if (typeof result !== 'object' || result === null) return attributes;
+  if (typeof result !== 'object' || result === null) {
+    return attributes;
+  }
 
   const resultObj = result as Record<string, unknown>;
 
-  if (typeof resultObj.description === 'string')
+  if (typeof resultObj.description === 'string') {
     attributes[MCP_PROMPT_RESULT_DESCRIPTION_ATTRIBUTE] = resultObj.description;
+  }
 
   if (Array.isArray(resultObj.messages)) {
     attributes[MCP_PROMPT_RESULT_MESSAGE_COUNT_ATTRIBUTE] = resultObj.messages.length;
 
     const messages = resultObj.messages;
     for (const [i, message] of messages.entries()) {
-      if (typeof message !== 'object' || message === null) continue;
+      if (typeof message !== 'object' || message === null) {
+        continue;
+      }
 
       const messageObj = message as Record<string, unknown>;
       const prefix = messages.length === 1 ? 'mcp.prompt.result' : `mcp.prompt.result.${i}`;

packages/core/src/integrations/mcp-server/sessionExtraction.ts

@@ -33,9 +33,15 @@ function extractPartyInfo(obj: unknown): PartyInfo {
 
   if (obj && typeof obj === 'object' && obj !== null) {
     const source = obj as Record<string, unknown>;
-    if (typeof source.name === 'string') partyInfo.name = source.name;
-    if (typeof source.title === 'string') partyInfo.title = source.title;
-    if (typeof source.version === 'string') partyInfo.version = source.version;
+    if (typeof source.name === 'string') {
+      partyInfo.name = source.name;
+    }
+    if (typeof source.title === 'string') {
+      partyInfo.title = source.title;
+    }
+    if (typeof source.version === 'string') {
+      partyInfo.version = source.version;
+    }
   }
 
   return partyInfo;
@@ -69,7 +75,9 @@ export function extractSessionDataFromInitializeResponse(result: unknown): Parti
   const sessionData: Partial<SessionData> = {};
   if (result && typeof result === 'object') {
     const resultObj = result as Record<string, unknown>;
-    if (typeof resultObj.protocolVersion === 'string') sessionData.protocolVersion = resultObj.protocolVersion;
+    if (typeof resultObj.protocolVersion === 'string') {
+      sessionData.protocolVersion = resultObj.protocolVersion;
+    }
     if (resultObj.serverInfo) {
       sessionData.serverInfo = extractPartyInfo(resultObj.serverInfo);
     }

packages/core/src/integrations/mcp-server/sessionManagement.ts

@@ -16,7 +16,9 @@ const transportToSessionData = new WeakMap<MCPTransport, SessionData>();
  * @param sessionData - Session data to store
  */
 export function storeSessionDataForTransport(transport: MCPTransport, sessionData: SessionData): void {
-  if (transport.sessionId) transportToSessionData.set(transport, sessionData);
+  if (transport.sessionId) {
+    transportToSessionData.set(transport, sessionData);
+  }
 }
 
 /**