Skip to content

Commit d3e9a08

Browse files
committed
fix(remix): Actually capture exceptions for HandleDocumentRequestFunction
1 parent 6e8e561 commit d3e9a08

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

packages/remix/src/server/errors.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,11 +101,10 @@ export function errorHandleDocumentRequestFunction(
101101
const { request, responseStatusCode, responseHeaders, context, loadContext } = requestContext;
102102

103103
return handleCallbackErrors(
104-
() => {
105-
return origDocumentRequestFunction.call(this, request, responseStatusCode, responseHeaders, context, loadContext);
106-
},
104+
() => origDocumentRequestFunction.call(this, request, responseStatusCode, responseHeaders, context, loadContext),
107105
err => {
108-
throw err;
106+
// eslint-disable-next-line @typescript-eslint/no-floating-promises
107+
captureRemixServerException(err, 'HandleDocumentRequestFunction', request);
109108
},
110109
);
111110
}

0 commit comments

Comments
 (0)