Skip to content

Commit d90d346

Browse files
committed
Rm eslint rules, todos
1 parent 6eab55f commit d90d346

File tree

3 files changed

+3
-9
lines changed

3 files changed

+3
-9
lines changed

packages/launchdarkly/.eslintrc.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,7 @@ module.exports = {
2121
{
2222
files: ['test/**/*.ts'],
2323

24-
rules: {
25-
// most of these errors come from `new Promise(process.nextTick)`
26-
'@typescript-eslint/unbound-method': 'off',
27-
// TODO: decide if we want to enable this again after the migration
28-
// We can take the freedom to be a bit more lenient with tests
29-
'@typescript-eslint/no-floating-promises': 'off',
30-
},
24+
rules: {},
3125
},
3226
{
3327
files: ['src/types/deprecated.ts'],

packages/launchdarkly/src/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export type LaunchDarklyOptions = Record<string, never>; //TODO:
1+
export type LaunchDarklyOptions = Record<string, never>; // Extend as needed.

packages/utils/src/flags.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export const FLAG_BUFFER_SIZE = 100;
1717
* oldest inserted flag is evicted.
1818
*/
1919
export function insertToFlagBuffer(flags: FeatureFlag[], name: string, value: boolean): void {
20-
// Check if the flag is already in the buffer
20+
// Check if the flag is already in the buffer - O(n)
2121
const index = flags.findIndex(f => f.flag === name);
2222

2323
if (index !== -1) {

0 commit comments

Comments
 (0)