Remove allowEviction

Author: aliu39

packages/core/src/utils/featureFlags.ts

@@ -83,14 +83,12 @@ export function _INTERNAL_insertFlagToScope(
  * @param name       Name of the feature flag to insert.
  * @param value      Value of the feature flag.
  * @param maxSize    Max number of flags the buffer should store. Default value should always be used in production.
- * @param allowEviction  If true, the oldest flag is evicted when the buffer is full. Otherwise the new flag is dropped.
  */
 export function _INTERNAL_insertToFlagBuffer(
   flags: FeatureFlag[],
   name: string,
   value: unknown,
   maxSize: number,
-  allowEviction: boolean = true,
 ): void {
   if (typeof value !== 'boolean') {
     return;
@@ -110,12 +108,8 @@ export function _INTERNAL_insertToFlagBuffer(
   }
 
   if (flags.length === maxSize) {
-    if (allowEviction) {
-      // If at capacity, pop the earliest flag - O(n)
-      flags.shift();
-    } else {
-      return;
-    }
+    // If at capacity, pop the earliest flag - O(n)
+    flags.shift();
   }
 
   // Push the flag to the end - O(1)

packages/core/test/lib/utils/featureFlags.test.ts

@@ -1,7 +1,10 @@
 import { afterEach, describe, expect, it, vi } from 'vitest';
 import { getCurrentScope } from '../../../src/currentScopes';
-import { type FeatureFlag } from '../../../src/featureFlags';
-import { _INTERNAL_insertFlagToScope, _INTERNAL_insertToFlagBuffer } from '../../../src/utils/featureFlags';
+import {
+  type FeatureFlag,
+  _INTERNAL_insertFlagToScope,
+  _INTERNAL_insertToFlagBuffer,
+} from '../../../src/utils/featureFlags';
 import { logger } from '../../../src/utils-hoist/logger';
 
 describe('flags', () => {
@@ -60,25 +63,6 @@ describe('flags', () => {
       ]);
     });
 
-    it('drops new entries when allowEviction is false and buffer is full', () => {
-      const buffer: FeatureFlag[] = [];
-      const maxSize = 0;
-      _INTERNAL_insertToFlagBuffer(buffer, 'feat1', true, maxSize, false);
-      _INTERNAL_insertToFlagBuffer(buffer, 'feat2', true, maxSize, false);
-      _INTERNAL_insertToFlagBuffer(buffer, 'feat3', true, maxSize, false);
-
-      expect(buffer).toEqual([]);
-    });
-
-    it('still updates order and values when allowEviction is false and buffer is full', () => {
-      const buffer: FeatureFlag[] = [];
-      const maxSize = 1;
-      _INTERNAL_insertToFlagBuffer(buffer, 'feat1', false, maxSize, false);
-      _INTERNAL_insertToFlagBuffer(buffer, 'feat1', true, maxSize, false);
-
-      expect(buffer).toEqual([{ flag: 'feat1', result: true }]);
-    });
-
     it('does not allocate unnecessary space', () => {
       const buffer: FeatureFlag[] = [];
       const maxSize = 1000;