also decode module field

Author: Lms24

dev-packages/node-integration-tests/suites/contextLines/test.ts

@@ -25,7 +25,7 @@ describe('ContextLines integration', () => {
                       lineno: 3,
                       function: '?',
                       in_app: true,
-                      module: 'scenario%20with%20space',
+                      module: 'scenario with space',
                     },
                   ]),
                 },

packages/node/src/utils/module.ts

@@ -29,23 +29,27 @@ export function createGetModuleFromFilename(
       file = file.slice(0, ext.length * -1);
     }
 
+    // The file name might be URI-encoded which we want to decode to
+    // the original file name.
+    const decodedFile = decodeURIComponent(file);
+
     if (!dir) {
       // No dirname whatsoever
       dir = '.';
     }
 
     const n = dir.lastIndexOf('/node_modules');
     if (n > -1) {
-      return `${dir.slice(n + 14).replace(/\//g, '.')}:${file}`;
+      return `${dir.slice(n + 14).replace(/\//g, '.')}:${decodedFile}`;
     }
 
     // Let's see if it's a part of the main module
     // To be a part of main module, it has to share the same base
     if (dir.startsWith(normalizedBase)) {
       const moduleName = dir.slice(normalizedBase.length + 1).replace(/\//g, '.');
-      return moduleName ? `${moduleName}:${file}` : file;
+      return moduleName ? `${moduleName}:${decodedFile}` : decodedFile;
     }
 
-    return file;
+    return decodedFile;
   };
 }

packages/node/test/utils/module.test.ts

@@ -16,6 +16,11 @@ describe('createGetModuleFromFilename', () => {
     expect(getModule('/path/to/base/file.js')).toBe('file');
   });
 
+  it('decodes URI-encoded file names', () => {
+    const getModule = createGetModuleFromFilename();
+    expect(getModule('/path%20with%space/file%20with%20spaces(1).js')).toBe('file with spaces(1)');
+  });
+
   it('returns undefined if no filename is provided', () => {
     const getModule = createGetModuleFromFilename();
     expect(getModule(undefined)).toBeUndefined();
@@ -29,7 +34,7 @@ describe('createGetModuleFromFilename', () => {
     expect(getModule(filename)).toBe(expected);
   });
 
-  it('handles windows paths with passed basePath', () => {
+  it('handles windows paths with passed basePath and node_modules', () => {
     const getModule = createGetModuleFromFilename('C:\\path\\to\\base', true);
     expect(getModule('C:\\path\\to\\base\\node_modules\\somePkg\\file.js')).toBe('somePkg:file');
   });