ref: Cleanup browser profiling integration (#10766)

This does two things:
1. Remove the deprecated class-based `BrowserProfilingIntegration`
2. Remove the `onProfilingStartRouteTransaction` method - this shouldn't
be needed anymore, as now the execution order of browser tracing is
ensured to be after browser profiling, ensuring that we had the chance
to register the `startTransaction` hook before browser tracing started a
transaction (as that now runs in `afterAllSetup`)

Author: mydea

packages/browser/src/index.ts

@@ -79,9 +79,4 @@ export {
 export type { SpanStatusType } from '@sentry/core';
 export type { Span } from '@sentry/types';
 export { makeBrowserOfflineTransport } from './transports/offline';
-export { onProfilingStartRouteTransaction } from './profiling/hubextensions';
-export {
-  // eslint-disable-next-line deprecation/deprecation
-  BrowserProfilingIntegration,
-  browserProfilingIntegration,
-} from './profiling/integration';
+export { browserProfilingIntegration } from './profiling/integration';

packages/browser/src/profiling/integration.ts

@@ -1,10 +1,10 @@
-import { convertIntegrationFnToClass, defineIntegration, getCurrentScope } from '@sentry/core';
-import type { Client, EventEnvelope, Integration, IntegrationClass, IntegrationFn, Transaction } from '@sentry/types';
+import { defineIntegration, getCurrentScope } from '@sentry/core';
+import type { EventEnvelope, IntegrationFn, Transaction } from '@sentry/types';
 import type { Profile } from '@sentry/types/src/profiling';
 import { logger } from '@sentry/utils';
 
 import { DEBUG_BUILD } from '../debug-build';
-import { startProfileForTransaction } from './hubextensions';
+import { startProfileForTransaction } from './startProfileForTransaction';
 import type { ProfiledEvent } from './utils';
 import {
   addProfilesToEnvelope,
@@ -97,22 +97,3 @@ const _browserProfilingIntegration = (() => {
 }) satisfies IntegrationFn;
 
 export const browserProfilingIntegration = defineIntegration(_browserProfilingIntegration);
-
-/**
- * Browser profiling integration. Stores any event that has contexts["profile"]["profile_id"]
- * This exists because we do not want to await async profiler.stop calls as transaction.finish is called
- * in a synchronous context. Instead, we handle sending the profile async from the promise callback and
- * rely on being able to pull the event from the cache when we need to construct the envelope. This makes the
- * integration less reliable as we might be dropping profiles when the cache is full.
- *
- * @experimental
- * @deprecated Use `browserProfilingIntegration()` instead.
- */
-// eslint-disable-next-line deprecation/deprecation
-export const BrowserProfilingIntegration = convertIntegrationFnToClass(
-  INTEGRATION_NAME,
-  browserProfilingIntegration,
-) as IntegrationClass<Integration & { setup: (client: Client) => void }>;
-
-// eslint-disable-next-line deprecation/deprecation
-export type BrowserProfilingIntegration = typeof BrowserProfilingIntegration;

packages/browser/src/profiling/hubextensions.ts renamed to packages/browser/src/profiling/startProfileForTransaction.ts

@@ -1,4 +1,3 @@
-/* eslint-disable complexity */
 import { spanToJSON } from '@sentry/core';
 import type { Transaction } from '@sentry/types';
 import { logger, timestampInSeconds, uuid4 } from '@sentry/utils';
@@ -10,32 +9,9 @@ import {
   MAX_PROFILE_DURATION_MS,
   addProfileToGlobalCache,
   isAutomatedPageLoadTransaction,
-  shouldProfileTransaction,
   startJSSelfProfile,
 } from './utils';
 
-/**
- * Safety wrapper for startTransaction for the unlikely case that transaction starts before tracing is imported -
- * if that happens we want to avoid throwing an error from profiling code.
- * see https://github.com/getsentry/sentry-javascript/issues/4731.
- *
- * @experimental
- */
-export function onProfilingStartRouteTransaction(transaction: Transaction | undefined): Transaction | undefined {
-  if (!transaction) {
-    if (DEBUG_BUILD) {
-      logger.log('[Profiling] Transaction is undefined, skipping profiling');
-    }
-    return transaction;
-  }
-
-  if (shouldProfileTransaction(transaction)) {
-    return startProfileForTransaction(transaction);
-  }
-
-  return transaction;
-}
-
 /**
  * Wraps startTransaction and stopTransaction with profiling related logic.
  * startProfileForTransaction is called after the call to startTransaction in order to avoid our own code from

packages/browser/test/unit/profiling/hubextensions.test.ts

@@ -48,9 +48,9 @@ describe('BrowserProfilingIntegration', () => {
 
     const client = Sentry.getClient<BrowserClient>();
 
-    // eslint-disable-next-line deprecation/deprecation
-    const currentTransaction = Sentry.getCurrentScope().getTransaction();
-    expect(currentTransaction?.op).toBe('pageload');
+    const currentTransaction = Sentry.getActiveSpan();
+    expect(currentTransaction).toBeDefined();
+    expect(Sentry.spanToJSON(currentTransaction!).op).toBe('pageload');
     currentTransaction?.end();
     await client?.flush(1000);