Skip to content

Commit debbf09

Browse files
committed
Rename to addFeatureFlag
1 parent b28bc63 commit debbf09

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

dev-packages/browser-integration-tests/suites/integrations/featureFlags/featureFlags/basic/test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ sentryTest('Basic test with eviction, update, and no async tasks', async ({ getL
2525
await page.evaluate(bufferSize => {
2626
const flagsIntegration = (window as any).Sentry.getClient().getIntegrationByName('FeatureFlags');
2727
for (let i = 1; i <= bufferSize; i++) {
28-
flagsIntegration.setFlag(`feat${i}`, false);
28+
flagsIntegration.addFeatureFlag(`feat${i}`, false);
2929
}
30-
flagsIntegration.setFlag(`feat${bufferSize + 1}`, true); // eviction
31-
flagsIntegration.setFlag('feat3', true); // update
30+
flagsIntegration.addFeatureFlag(`feat${bufferSize + 1}`, true); // eviction
31+
flagsIntegration.addFeatureFlag('feat3', true); // update
3232
return true;
3333
}, FLAG_BUFFER_SIZE);
3434

dev-packages/browser-integration-tests/suites/integrations/featureFlags/featureFlags/withScope/test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,18 +30,18 @@ sentryTest('Flag evaluations in forked scopes are stored separately.', async ({
3030
const errorButton = document.querySelector('#error') as HTMLButtonElement;
3131
const flagsIntegration = (window as any).Sentry.getClient().getIntegrationByName('FeatureFlags');
3232

33-
flagsIntegration.setFlag('shared', true);
33+
flagsIntegration.addFeatureFlag('shared', true);
3434

3535
Sentry.withScope((scope: Scope) => {
36-
flagsIntegration.setFlag('forked', true);
37-
flagsIntegration.setFlag('shared', false);
36+
flagsIntegration.addFeatureFlag('forked', true);
37+
flagsIntegration.addFeatureFlag('shared', false);
3838
scope.setTag('isForked', true);
3939
if (errorButton) {
4040
errorButton.click();
4141
}
4242
});
4343

44-
flagsIntegration.setFlag('main', true);
44+
flagsIntegration.addFeatureFlag('main', true);
4545
Sentry.getCurrentScope().setTag('isForked', false);
4646
errorButton.click();
4747
return true;

packages/browser/src/integrations/featureFlags/featureFlagsIntegration.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { defineIntegration } from '@sentry/core';
44
import { copyFlagsFromScopeToEvent, insertFlagToScope } from '../../utils/featureFlags';
55

66
export interface FeatureFlagsIntegration extends Integration {
7-
setFlag: (name: string, value: unknown) => void;
7+
addFeatureFlag: (name: string, value: unknown) => void;
88
}
99

1010
/**
@@ -25,7 +25,7 @@ export interface FeatureFlagsIntegration extends Integration {
2525
* // Verify
2626
* const flagsIntegration = Sentry.getClient()?.getIntegrationByName<FeatureFlagsIntegration>('FeatureFlags');
2727
* if (flagsIntegration) {
28-
* flagsIntegration.setFlag('my-flag', true);
28+
* flagsIntegration.addFeatureFlag('my-flag', true);
2929
* } else {
3030
* // check your setup
3131
* }
@@ -40,7 +40,7 @@ export const featureFlagsIntegration = defineIntegration(() => {
4040
return copyFlagsFromScopeToEvent(event);
4141
},
4242

43-
setFlag(name: string, value: unknown): void {
43+
addFeatureFlag(name: string, value: unknown): void {
4444
insertFlagToScope(name, value);
4545
},
4646
};

0 commit comments

Comments
 (0)