fix(profiling) shim __dirname for esm

Author: JonasBa

packages/profiling-node/rollup.npm.config.mjs

@@ -2,13 +2,20 @@ import commonjs from '@rollup/plugin-commonjs';
 import { makeBaseNPMConfig, makeNPMConfigVariants } from '@sentry-internal/rollup-utils';
 
 export const ESMImportShim = `
-import cjsModule from 'node:module';
+import {createRequire} from 'node:module';
+import {fileURLToPath} from 'node:url';
+import {dirname } from 'node:path';
 `;
 
 const ESMRequireShim = `
-const require = cjsModule.createRequire(import.meta.url);
+const require = createRequire(import.meta.url);
 `;
 
+const ESMDirnameShim = `
+const filename = fileURLToPath(import.meta.url);
+const __dirname = dirname(__filename);
+`
+
 function makeESMImportShimPlugin(shim) {
   return {
     transform(code) {
@@ -27,6 +34,15 @@ function makeESMRequireShimPlugin(shim) {
   };
 }
 
+function makeESMDirnameShimPlugin(shim){
+  return {
+    transform(code){
+      const SHIM_REGEXP = /\/\/ #START_SENTRY_ESM_DIRNAME_SHIM[\s\S]*?\/\/ #END_SENTRY_ESM_DIRNAME_SHIM/
+      return code.replace(SHIM_REGEXP, shim);
+    }
+  }
+}
+
 const variants = makeNPMConfigVariants(
   makeBaseNPMConfig({
     packageSpecificConfig: {
@@ -40,10 +56,12 @@ for (const variant of variants) {
   if (variant.output.format === 'esm') {
     variant.plugins.push(makeESMImportShimPlugin(ESMImportShim));
     variant.plugins.push(makeESMRequireShimPlugin(ESMRequireShim));
+    variant.plugins.push(makeESMDirnameShimPlugin(ESMDirnameShim));
   } else {
     // Remove the ESM shim comment
     variant.plugins.push(makeESMImportShimPlugin(''));
     variant.plugins.push(makeESMRequireShimPlugin(''));
+    variant.plugins.push(makeESMDirnameShimPlugin(''));
   }
 }
 

packages/profiling-node/src/cpu_profiler.ts

@@ -1,5 +1,5 @@
 import { arch as _arch, platform as _platform } from 'node:os';
-import { join, resolve } from 'node:path';
+import { join, resolve} from 'node:path';
 import { env, versions } from 'node:process';
 import { threadId } from 'node:worker_threads';
 import { familySync } from 'detect-libc';
@@ -27,17 +27,13 @@ const arch = process.env['BUILD_ARCH'] || _arch();
 const abi = getAbi(versions.node, 'node');
 const identifier = [platform, arch, stdlib, abi].filter(c => c !== undefined && c !== null).join('-');
 
-const built_from_source_path = resolve(__dirname, '..', `./sentry_cpu_profiler-${identifier}`);
-
 /**
  *  Imports cpp bindings based on the current platform and architecture.
  */
 // eslint-disable-next-line complexity
 export function importCppBindingsModule(): PrivateV8CpuProfilerBindings {
   // #START_SENTRY_ESM_REQUIRE_SHIM
-  // When building for ESM, we shim require to use createRequire and __dirname.
-  // We need to do this because .node extensions in esm are not supported.
-  // The comment below this line exists as a placeholder for where to insert the shim.
+  // When building for ESM, we shim require to use createRequire because .node extensions in esm are not supported.
   // #END_SENTRY_ESM_REQUIRE_SHIM
 
   // If a binary path is specified, use that.
@@ -165,6 +161,12 @@ export function importCppBindingsModule(): PrivateV8CpuProfilerBindings {
       }
     }
   }
+
+  // #START_SENTRY_ESM_DIRNAME_SHIM
+  // const filename = fileURLToPath(import.meta.url);
+  // const __dirname = dirname(filename);
+  // #END_SENTRY_ESM_DIRNAME_SHIM
+  const built_from_source_path = resolve(__dirname, '..', `./sentry_cpu_profiler-${identifier}`);
   return require(`${built_from_source_path}.node`);
 }