Skip to content

Commit e58f079

Browse files
committed
review suggestions
1 parent 2935bee commit e58f079

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

dev-packages/e2e-tests/test-applications/nuxt-3/pages/client-error.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ const catchErr = () => {
77
</script>
88

99
<template>
10-
<ErrorButton id="errorBtn" error-text="Error thrown from Nuxt-4 E2E test app"/>
11-
<ErrorButton id="errorBtn2" error-text="Another Error thrown from Nuxt-4 E2E test app"/>
10+
<ErrorButton id="errorBtn" error-text="Error thrown from Nuxt-3 E2E test app"/>
11+
<ErrorButton id="errorBtn2" error-text="Another Error thrown from Nuxt-3 E2E test app"/>
1212

1313
<NuxtErrorBoundary @error="catchErr">
14-
<ErrorButton id="errorBtn3" error-text="Error thrown in Error Boundary"/>
14+
<ErrorButton id="error-in-error-boundary" error-text="Error thrown in Error Boundary"/>
1515
</NuxtErrorBoundary>
1616
</template>

dev-packages/e2e-tests/test-applications/nuxt-3/tests/errors.client.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ test.describe('client-side errors', async () => {
3434
});
3535

3636
await page.goto(`/client-error`);
37-
await page.locator('#errorBtn3').click();
37+
await page.locator('#error-in-error-boundary').click();
3838

3939
const error = await errorPromise;
4040

dev-packages/e2e-tests/test-applications/nuxt-4/app/pages/client-error.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@ const catchErr = () => {
1111
<ErrorButton id="errorBtn2" error-text="Another Error thrown from Nuxt-4 E2E test app"/>
1212

1313
<NuxtErrorBoundary @error="catchErr">
14-
<ErrorButton id="errorBtn3" error-text="Error thrown in Error Boundary"/>
14+
<ErrorButton id="error-in-error-boundary" error-text="Error thrown in Error Boundary"/>
1515
</NuxtErrorBoundary>
1616
</template>

dev-packages/e2e-tests/test-applications/nuxt-4/tests/errors.client.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ test.describe('client-side errors', async () => {
3434
});
3535

3636
await page.goto(`/client-error`);
37-
await page.locator('#errorBtn3').click();
37+
await page.locator('#error-in-error-boundary').click();
3838

3939
const error = await errorPromise;
4040

0 commit comments

Comments
 (0)