Skip to content

Commit e5ac491

Browse files
committed
Fix nestjs-11 e2e tests
1 parent be79b6f commit e5ac491

File tree

1 file changed

+4
-8
lines changed
  • dev-packages/e2e-tests/test-applications/nestjs-11/tests

1 file changed

+4
-8
lines changed

dev-packages/e2e-tests/test-applications/nestjs-11/tests/errors.test.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,11 @@ test('Does not send HttpExceptions to Sentry', async ({ baseURL }) => {
5050
});
5151

5252
const transactionEventPromise400 = waitForTransaction('nestjs-11', transactionEvent => {
53-
// todo(express-5): parametrize /test-expected-400-exception/:id
54-
return transactionEvent?.transaction === 'GET /test-expected-400-exception/123';
53+
return transactionEvent?.transaction === 'GET /test-expected-400-exception/:id';
5554
});
5655

5756
const transactionEventPromise500 = waitForTransaction('nestjs-11', transactionEvent => {
58-
// todo(express-5): parametrize /test-expected-500-exception/:id
59-
return transactionEvent?.transaction === 'GET /test-expected-500-exception/123';
57+
return transactionEvent?.transaction === 'GET /test-expected-500-exception/:id';
6058
});
6159

6260
const response400 = await fetch(`${baseURL}/test-expected-400-exception/123`);
@@ -81,13 +79,11 @@ test('Does not send RpcExceptions to Sentry', async ({ baseURL }) => {
8179
errorEventOccurred = true;
8280
}
8381

84-
// todo(express-5): parametrize /test-expected-rpc-exception/:id
85-
return event?.transaction === 'GET /test-expected-rpc-exception/123';
82+
return event?.transaction === 'GET /test-expected-rpc-exception/:id';
8683
});
8784

8885
const transactionEventPromise = waitForTransaction('nestjs-11', transactionEvent => {
89-
// todo(express-5): parametrize /test-expected-rpc-exception/:id
90-
return transactionEvent?.transaction === 'GET /test-expected-rpc-exception/123';
86+
return transactionEvent?.transaction === 'GET /test-expected-rpc-exception/:id';
9187
});
9288

9389
const response = await fetch(`${baseURL}/test-expected-rpc-exception/123`);

0 commit comments

Comments
 (0)