Merge branch 'develop' into billy/replay-575-replay-w-linked-errors-from-prior-week

Author: billyvg

.cursor/rules/publishing_release.mdc

@@ -14,7 +14,7 @@ The release process is outlined in [publishing-a-release.md](mdc:docs/publishing
 
 1. Make sure you are on the latest version of the `develop` branch. To confirm this, run `git pull origin develop` to get the latest changes from the repo.
 2. Run `yarn changelog` on the `develop` branch and copy the output. You can use `yarn changelog | pbcopy` to copy the output of `yarn changelog` into your clipboard.
-3. Decide on a version for the release based on [semver](mdc:https://semver.org). The version should be decided based on what is in included in the release. For example, if the release includes a new feature, we should increment the minor version. If it includes only bug fixes, we should increment the patch version.
+3. Decide on a version for the release based on [semver](mdc:https://semver.org). The version should be decided based on what is in included in the release. For example, if the release includes a new feature, we should increment the minor version. If it includes only bug fixes, we should increment the patch version. You can find the latest version in [CHANGELOG.md](mdc:CHANGELOG.md) at the very top.
 4. Create a branch `prepare-release/VERSION`, eg. `prepare-release/8.1.0`, off `develop`.
 5. Update [CHANGELOG.md](mdc:CHANGELOG.md) to add an entry for the next release number and a list of changes since the last release from the output of `yarn changelog`. See the `Updating the Changelog` section in [publishing-a-release.md](mdc:docs/publishing-a-release.md) for more details. If you remove changelog entries because they are not applicable, please let the user know.
 6. Commit the changes to [CHANGELOG.md](mdc:CHANGELOG.md) with `meta(changelog): Update changelog for VERSION` where `VERSION` is the version of the release, e.g. `meta(changelog): Update changelog for 8.1.0`

.size-limit.js

@@ -38,7 +38,7 @@ module.exports = [
     path: 'packages/browser/build/npm/esm/index.js',
     import: createImport('init', 'browserTracingIntegration'),
     gzip: true,
-    limit: '40.7 KB',
+    limit: '41 KB',
   },
   {
     name: '@sentry/browser (incl. Tracing, Replay)',
@@ -82,7 +82,7 @@ module.exports = [
     path: 'packages/browser/build/npm/esm/index.js',
     import: createImport('init', 'browserTracingIntegration', 'replayIntegration', 'feedbackIntegration'),
     gzip: true,
-    limit: '96 KB',
+    limit: '97 KB',
   },
   {
     name: '@sentry/browser (incl. Feedback)',
@@ -96,14 +96,14 @@ module.exports = [
     path: 'packages/browser/build/npm/esm/index.js',
     import: createImport('init', 'sendFeedback'),
     gzip: true,
-    limit: '29 KB',
+    limit: '30 KB',
   },
   {
     name: '@sentry/browser (incl. FeedbackAsync)',
     path: 'packages/browser/build/npm/esm/index.js',
     import: createImport('init', 'feedbackAsyncIntegration'),
     gzip: true,
-    limit: '34 KB',
+    limit: '35 KB',
   },
   // React SDK (ESM)
   {
@@ -128,7 +128,7 @@ module.exports = [
     path: 'packages/vue/build/esm/index.js',
     import: createImport('init'),
     gzip: true,
-    limit: '29 KB',
+    limit: '30 KB',
   },
   {
     name: '@sentry/vue (incl. Tracing)',
@@ -150,13 +150,13 @@ module.exports = [
     name: 'CDN Bundle',
     path: createCDNPath('bundle.min.js'),
     gzip: true,
-    limit: '26 KB',
+    limit: '27 KB',
   },
   {
     name: 'CDN Bundle (incl. Tracing)',
     path: createCDNPath('bundle.tracing.min.js'),
     gzip: true,
-    limit: '41 KB',
+    limit: '42 KB',
   },
   {
     name: 'CDN Bundle (incl. Tracing, Replay)',
@@ -183,7 +183,7 @@ module.exports = [
     path: createCDNPath('bundle.tracing.min.js'),
     gzip: false,
     brotli: false,
-    limit: '120 KB',
+    limit: '123 KB',
   },
   {
     name: 'CDN Bundle (incl. Tracing, Replay) - uncompressed',
@@ -215,7 +215,7 @@ module.exports = [
     import: createImport('init'),
     ignore: ['$app/stores'],
     gzip: true,
-    limit: '41 KB',
+    limit: '42 KB',
   },
   // Node-Core SDK (ESM)
   {

CHANGELOG.md

@@ -4,6 +4,19 @@
 
 - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
 
+Work in this release was contributed by @seoyeon9888. Thank you for your contribution!
+
+## 10.19.0
+
+- feat(tracemetrics): Add trace metrics behind an experiments flag ([#17883](https://github.com/getsentry/sentry-javascript/pull/17883))
+
+<details>
+  <summary> <strong>Internal Changes</strong> </summary>
+
+- chore: add info latest release for the cursor release command ([#17876](https://github.com/getsentry/sentry-javascript/pull/17876))
+
+</details>
+
 ## 10.18.0
 
 ### Important Changes

dev-packages/browser-integration-tests/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry-internal/browser-integration-tests",
-  "version": "10.18.0",
+  "version": "10.19.0",
   "main": "index.js",
   "license": "MIT",
   "engines": {
@@ -43,7 +43,7 @@
     "@babel/preset-typescript": "^7.16.7",
     "@playwright/test": "~1.53.2",
     "@sentry-internal/rrweb": "2.34.0",
-    "@sentry/browser": "10.18.0",
+    "@sentry/browser": "10.19.0",
     "@supabase/supabase-js": "2.49.3",
     "axios": "^1.12.2",
     "babel-loader": "^8.2.2",

dev-packages/browser-integration-tests/suites/integrations/featureFlags/growthbook/onError/basic/test.ts

@@ -0,0 +1,68 @@
+import { expect } from '@playwright/test';
+import { _INTERNAL_FLAG_BUFFER_SIZE as FLAG_BUFFER_SIZE } from '@sentry/core';
+import { sentryTest } from '../../../../../../utils/fixtures';
+import {
+  envelopeRequestParser,
+  shouldSkipFeatureFlagsTest,
+  waitForErrorRequest,
+} from '../../../../../../utils/helpers';
+
+sentryTest('GrowthBook onError: basic eviction/update and no async tasks', async ({ getLocalTestUrl, page }) => {
+  if (shouldSkipFeatureFlagsTest()) {
+    sentryTest.skip();
+  }
+
+  await page.route('https://dsn.ingest.sentry.io/**/*', route => {
+    return route.fulfill({ status: 200, contentType: 'application/json', body: JSON.stringify({ id: 'test-id' }) });
+  });
+
+  const url = await getLocalTestUrl({ testDir: __dirname, skipDsnRouteHandler: true });
+  await page.goto(url);
+
+  await page.evaluate(bufferSize => {
+    const gb = new (window as any).GrowthBook();
+
+    for (let i = 1; i <= bufferSize; i++) {
+      gb.isOn(`feat${i}`);
+    }
+
+    gb.__setOn(`feat${bufferSize + 1}`, true);
+    gb.isOn(`feat${bufferSize + 1}`); // eviction
+
+    gb.__setOn('feat3', true);
+    gb.isOn('feat3'); // update
+
+    // Test getFeatureValue with boolean values (should be captured)
+    gb.__setFeatureValue('bool-feat', true);
+    gb.getFeatureValue('bool-feat', false);
+
+    // Test getFeatureValue with non-boolean values (should be ignored)
+    gb.__setFeatureValue('string-feat', 'hello');
+    gb.getFeatureValue('string-feat', 'default');
+    gb.__setFeatureValue('number-feat', 42);
+    gb.getFeatureValue('number-feat', 0);
+  }, FLAG_BUFFER_SIZE);
+
+  const reqPromise = waitForErrorRequest(page);
+  await page.locator('#error').click();
+  const req = await reqPromise;
+  const event = envelopeRequestParser(req);
+
+  const values = event.contexts?.flags?.values || [];
+
+  // After the sequence of operations:
+  // 1. feat1-feat100 are added (100 items)
+  // 2. feat101 is added, evicts feat1 (100 items: feat2-feat100, feat101)
+  // 3. feat3 is updated to true, moves to end (100 items: feat2, feat4-feat100, feat101, feat3)
+  // 4. bool-feat is added, evicts feat2 (100 items: feat4-feat100, feat101, feat3, bool-feat)
+
+  const expectedFlags = [];
+  for (let i = 4; i <= FLAG_BUFFER_SIZE; i++) {
+    expectedFlags.push({ flag: `feat${i}`, result: false });
+  }
+  expectedFlags.push({ flag: `feat${FLAG_BUFFER_SIZE + 1}`, result: true });
+  expectedFlags.push({ flag: 'feat3', result: true });
+  expectedFlags.push({ flag: 'bool-feat', result: true }); // Only boolean getFeatureValue should be captured
+
+  expect(values).toEqual(expectedFlags);
+});

dev-packages/browser-integration-tests/suites/integrations/featureFlags/growthbook/onError/init.js

@@ -0,0 +1,37 @@
+import * as Sentry from '@sentry/browser';
+
+// Minimal mock GrowthBook class for tests
+window.GrowthBook = class {
+  constructor() {
+    this._onFlags = Object.create(null);
+    this._featureValues = Object.create(null);
+  }
+
+  isOn(featureKey) {
+    return !!this._onFlags[featureKey];
+  }
+
+  getFeatureValue(featureKey, defaultValue) {
+    return Object.prototype.hasOwnProperty.call(this._featureValues, featureKey)
+      ? this._featureValues[featureKey]
+      : defaultValue;
+  }
+
+  // Helpers for tests
+  __setOn(featureKey, value) {
+    this._onFlags[featureKey] = !!value;
+  }
+
+  __setFeatureValue(featureKey, value) {
+    this._featureValues[featureKey] = value;
+  }
+};
+
+window.Sentry = Sentry;
+window.sentryGrowthBookIntegration = Sentry.growthbookIntegration({ growthbookClass: window.GrowthBook });
+
+Sentry.init({
+  dsn: 'https://[email protected]/1337',
+  sampleRate: 1.0,
+  integrations: [window.sentryGrowthBookIntegration],
+});

dev-packages/browser-integration-tests/suites/integrations/featureFlags/growthbook/onError/subject.js

@@ -0,0 +1,3 @@
+document.getElementById('error').addEventListener('click', () => {
+  throw new Error('Button triggered error');
+});

dev-packages/browser-integration-tests/suites/integrations/featureFlags/growthbook/onError/template.html

@@ -0,0 +1,12 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <meta charset="utf-8" />
+  </head>
+  <body>
+    <button id="error">Throw Error</button>
+  </body>
+  <script src="./subject.js"></script>
+</html>
+
+

dev-packages/browser-integration-tests/suites/integrations/featureFlags/growthbook/onError/withScope/test.ts

@@ -0,0 +1,65 @@
+import { expect } from '@playwright/test';
+import type { Scope } from '@sentry/browser';
+import { sentryTest } from '../../../../../../utils/fixtures';
+import {
+  envelopeRequestParser,
+  shouldSkipFeatureFlagsTest,
+  waitForErrorRequest,
+} from '../../../../../../utils/helpers';
+
+sentryTest('GrowthBook onError: forked scopes are isolated', async ({ getLocalTestUrl, page }) => {
+  if (shouldSkipFeatureFlagsTest()) {
+    sentryTest.skip();
+  }
+
+  await page.route('https://dsn.ingest.sentry.io/**/*', route => {
+    return route.fulfill({ status: 200, contentType: 'application/json', body: JSON.stringify({ id: 'test-id' }) });
+  });
+
+  const url = await getLocalTestUrl({ testDir: __dirname, skipDsnRouteHandler: true });
+  await page.goto(url);
+
+  const forkedReqPromise = waitForErrorRequest(page, event => !!event.tags?.isForked === true);
+  const mainReqPromise = waitForErrorRequest(page, event => !!event.tags?.isForked === false);
+
+  await page.evaluate(() => {
+    const Sentry = (window as any).Sentry;
+    const errorButton = document.querySelector('#error') as HTMLButtonElement;
+    const gb = new (window as any).GrowthBook();
+
+    gb.__setOn('shared', true);
+    gb.__setOn('main', true);
+
+    gb.isOn('shared');
+
+    Sentry.withScope((scope: Scope) => {
+      gb.__setOn('forked', true);
+      gb.__setOn('shared', false);
+      gb.isOn('forked');
+      gb.isOn('shared');
+      scope.setTag('isForked', true);
+      errorButton.click();
+    });
+
+    gb.isOn('main');
+    Sentry.getCurrentScope().setTag('isForked', false);
+    errorButton.click();
+    return true;
+  });
+
+  const forkedReq = await forkedReqPromise;
+  const forkedEvent = envelopeRequestParser(forkedReq);
+
+  const mainReq = await mainReqPromise;
+  const mainEvent = envelopeRequestParser(mainReq);
+
+  expect(forkedEvent.contexts?.flags?.values).toEqual([
+    { flag: 'forked', result: true },
+    { flag: 'shared', result: false },
+  ]);
+
+  expect(mainEvent.contexts?.flags?.values).toEqual([
+    { flag: 'shared', result: true },
+    { flag: 'main', result: true },
+  ]);
+});

dev-packages/browser-integration-tests/suites/integrations/featureFlags/growthbook/onSpan/init.js

@@ -0,0 +1,39 @@
+import * as Sentry from '@sentry/browser';
+
+window.GrowthBook = class {
+  constructor() {
+    this._onFlags = Object.create(null);
+    this._featureValues = Object.create(null);
+  }
+
+  isOn(featureKey) {
+    return !!this._onFlags[featureKey];
+  }
+
+  getFeatureValue(featureKey, defaultValue) {
+    return Object.prototype.hasOwnProperty.call(this._featureValues, featureKey)
+      ? this._featureValues[featureKey]
+      : defaultValue;
+  }
+
+  __setOn(featureKey, value) {
+    this._onFlags[featureKey] = !!value;
+  }
+
+  __setFeatureValue(featureKey, value) {
+    this._featureValues[featureKey] = value;
+  }
+};
+
+window.Sentry = Sentry;
+window.sentryGrowthBookIntegration = Sentry.growthbookIntegration({ growthbookClass: window.GrowthBook });
+
+Sentry.init({
+  dsn: 'https://[email protected]/1337',
+  sampleRate: 1.0,
+  tracesSampleRate: 1.0,
+  integrations: [
+    window.sentryGrowthBookIntegration,
+    Sentry.browserTracingIntegration({ instrumentNavigation: false, instrumentPageLoad: false }),
+  ],
+});