Skip to content

Commit e8388e8

Browse files
Zen-cronicmydea
authored andcommitted
test(node): add comments about why AxiosError is tested
1 parent d48d0d5 commit e8388e8

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

dev-packages/node-integration-tests/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
"cors": "^2.8.5",
4545
"cron": "^3.1.6",
4646
"express": "^4.17.3",
47+
"fastify": "^4.23.2",
4748
"graphql": "^16.3.0",
4849
"http-terminator": "^3.2.0",
4950
"ioredis": "^5.4.1",

dev-packages/node-integration-tests/suites/fastify/deprecation/test.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,14 @@ afterAll(() => {
55
cleanupChildProcesses();
66
});
77

8+
/**
9+
* AxiosError throws before the deprecation warning code is invoked,
10+
* so mocking it would have no effect.
11+
*
12+
* But the deprecation warning is successfully suppressed.
13+
* This can be verified by running the example code as in the original
14+
* issue (https://github.com/getsentry/sentry-javascript/issues/12844)
15+
*/
816
test('suppress fastify deprecation warning when `routerPath` property is accessed', async () => {
917
// ensures that the assertions in the catch block are called
1018
expect.assertions(3);

0 commit comments

Comments
 (0)