Don't capture start/spawn breadcrumbs

Author: timfish

dev-packages/node-integration-tests/suites/breadcrumbs/process-thread/app.mjs

@@ -13,12 +13,14 @@ Sentry.init({
 });
 
 await new Promise(resolve => {
-  const child = spawn('sleep', ['1']);
+  const child = spawn('sleep', ['a']);
+  child.on('error', resolve);
   child.on('exit', resolve);
 });
 
 await new Promise(resolve => {
   const worker = new Worker(join(__dirname, 'worker.mjs'));
+  worker.on('error', resolve);
   worker.on('exit', resolve);
 });
 

dev-packages/node-integration-tests/suites/breadcrumbs/process-thread/test.ts

@@ -16,35 +16,17 @@ const EVENT = {
     {
       timestamp: expect.any(Number),
       category: 'child_process',
-      message: 'Child process spawned',
-      level: 'info',
+      message: "Child process exited with code '1'",
+      level: 'warning',
       data: {
         spawnfile: 'sleep',
       },
     },
-    {
-      timestamp: expect.any(Number),
-      category: 'child_process',
-      message: "Child process exited with code '0'",
-      level: 'info',
-      data: {
-        spawnfile: 'sleep',
-      },
-    },
-    {
-      timestamp: expect.any(Number),
-      category: 'worker_thread',
-      message: 'Worker thread online',
-      level: 'info',
-      data: {
-        threadId: expect.any(Number),
-      },
-    },
     {
       timestamp: expect.any(Number),
       category: 'worker_thread',
-      message: "Worker thread exited with code '0'",
-      level: 'info',
+      message: "Worker thread errored with 'Worker error'",
+      level: 'error',
       data: {
         threadId: expect.any(Number),
       },

dev-packages/node-integration-tests/suites/breadcrumbs/process-thread/worker.mjs

@@ -1,3 +1 @@
-setTimeout(() => {
-  // do nothing and then exit
-}, 1000);
+throw new Error('Worker error');

packages/node/src/integrations/processThread.ts

@@ -37,67 +37,54 @@ const _processThreadBreadcrumbIntegration = ((options: Options = {}) => {
 }) satisfies IntegrationFn;
 
 /**
- * Capture breadcrumbs for child process and thread creation, exit and error.
+ * Capture breadcrumbs for child processes and worker threads.
  */
 export const processThreadBreadcrumbIntegration = defineIntegration(_processThreadBreadcrumbIntegration);
 
 function captureChildProcessEvents(child: ChildProcess, options: Options): void {
   let hasExited = false;
   let data: Record<string, unknown> | undefined;
 
-  child.on('spawn', () => {
-    // This is Sentry getting macOS OS context
-    if (child.spawnfile === '/usr/bin/sw_vers') {
-      hasExited = true;
-      return;
-    }
-
-    data = { spawnfile: child.spawnfile };
-    if (options.includeChildProcessArgs) {
-      data.spawnargs = child.spawnargs;
-    }
-
-    addBreadcrumb({
-      category: 'child_process',
-      message: 'Child process spawned',
-      level: 'info',
-      data,
-    });
-  });
-
-  child.on('exit', (code, signal) => {
-    if (!hasExited) {
-      hasExited = true;
+  child
+    .on('spawn', () => {
+      // This is Sentry getting macOS OS context
+      if (child.spawnfile === '/usr/bin/sw_vers') {
+        hasExited = true;
+        return;
+      }
 
-      let message = 'Child process exited';
-      if (code !== null) {
-        message += ` with code '${code}'`;
+      data = { spawnfile: child.spawnfile };
+      if (options.includeChildProcessArgs) {
+        data.spawnargs = child.spawnargs;
       }
-      if (signal !== null) {
-        message += ` with signal '${signal}'`;
+    })
+    .on('exit', code => {
+      if (!hasExited) {
+        hasExited = true;
+
+        // Only log for non-zero exit codes
+        if (code !== null && code !== 0) {
+          addBreadcrumb({
+            category: 'child_process',
+            message: `Child process exited with code '${code}'`,
+            level: 'warning',
+            data,
+          });
+        }
       }
-
-      addBreadcrumb({
-        category: 'child_process',
-        message,
-        level: code !== 0 ? 'warning' : 'info',
-        data,
-      });
-    }
-  });
-
-  child.on('error', error => {
-    if (!hasExited) {
-      hasExited = true;
-
-      addBreadcrumb({
-        category: 'child_process',
-        message: `Child process errored with ${error.message}`,
-        level: 'error',
-        data,
-      });
-    }
-  });
+    })
+    .on('error', error => {
+      if (!hasExited) {
+        hasExited = true;
+
+        addBreadcrumb({
+          category: 'child_process',
+          message: `Child process errored with '${error.message}'`,
+          level: 'error',
+          data,
+        });
+      }
+    });
 }
 
 function captureWorkerThreadEvents(worker: Worker): void {
@@ -106,26 +93,11 @@ function captureWorkerThreadEvents(worker: Worker): void {
   worker
     .on('online', () => {
       threadId = worker.threadId;
-
-      addBreadcrumb({
-        category: 'worker_thread',
-        message: 'Worker thread online',
-        level: 'info',
-        data: { threadId },
-      });
-    })
-    .on('exit', code => {
-      addBreadcrumb({
-        category: 'worker_thread',
-        message: `Worker thread exited with code '${code}'`,
-        level: code !== 0 ? 'warning' : 'info',
-        data: { threadId },
-      });
     })
     .on('error', error => {
       addBreadcrumb({
         category: 'worker_thread',
-        message: `Worker thread errored with ${error.message}`,
+        message: `Worker thread errored with '${error.message}'`,
         level: 'error',
         data: { threadId },
       });