stop using object.assign

Author: mydea

packages/core/src/integration.ts

@@ -2,6 +2,7 @@ import type {
   Client,
   Event,
   EventHint,
+  EventProcessor,
   Integration,
   IntegrationClass,
   IntegrationFn,
@@ -148,9 +149,9 @@ export function setupIntegration(client: Client, integration: Integration, integ
   if (client.addEventProcessor && typeof integration.processEvent === 'function') {
     const callback = integration.processEvent.bind(integration) as typeof integration.processEvent;
 
-    const processor = Object.assign((event: Event, hint: EventHint) => callback(event, hint, client), {
-      id: integration.name,
-    });
+    const processor: EventProcessor = (event: Event, hint: EventHint): ReturnType<typeof callback> =>
+      callback(event, hint, client);
+    processor.id = integration.name;
 
     client.addEventProcessor(processor);
   }
@@ -191,12 +192,11 @@ export function convertIntegrationFnToClass<Fn extends IntegrationFn>(
   name: string,
   fn: Fn,
 ): IntegrationClass<Integration> {
-  return Object.assign(
-    function ConvertedIntegration(...args: Parameters<Fn>): Integration {
-      return fn(...args);
-    },
-    { id: name },
-  ) as unknown as IntegrationClass<Integration>;
+  const ConvertedIntegration = function ConvertedIntegration(...args: Parameters<Fn>): Integration {
+    return fn(...args);
+  };
+  ConvertedIntegration.id = name;
+  return ConvertedIntegration as unknown as IntegrationClass<Integration>;
 }
 
 /**

packages/eslint-plugin-sdk/src/rules/no-unsupported-es6-methods.js

@@ -20,9 +20,10 @@ module.exports = {
         const functionName = node.callee.property.name;
 
         const es6ArrayFunctions = ['copyWithin', 'values', 'fill'];
+        const es6ObjectFunctions = ['assign'];
         const es6StringFunctions = ['repeat'];
 
-        const es6Functions = [].concat(es6ArrayFunctions, es6StringFunctions);
+        const es6Functions = [].concat(es6ArrayFunctions, es6StringFunctions, es6ObjectFunctions);
         if (es6Functions.indexOf(functionName) > -1) {
           context.report({
             node: node.callee.property,

packages/tracing-internal/src/browser/web-vitals/lib/observe.ts

@@ -49,15 +49,11 @@ export const observe = <K extends keyof PerformanceEntryMap>(
       const po = new PerformanceObserver(list => {
         callback(list.getEntries() as PerformanceEntryMap[K]);
       });
-      po.observe(
-        Object.assign(
-          {
-            type,
-            buffered: true,
-          },
-          opts || {},
-        ) as PerformanceObserverInit,
-      );
+      po.observe({
+        type,
+        buffered: true,
+        ...opts,
+      } as PerformanceObserverInit);
       return po;
     }
   } catch (e) {