cleanup, remove unnecessary log

Author: Lms24

packages/browser-utils/src/metrics/cls.ts

@@ -79,7 +79,6 @@ function sendStandaloneClsSpan(
   }
 
   const span = startStandaloneWebVitalSpan({
-    type: 'cls',
     name,
     transaction: routeName,
     attributes,

packages/browser-utils/src/metrics/inp.ts

@@ -129,7 +129,6 @@ export const _onInp: InstrumentationHandlerCallback = ({ metric }) => {
   };
 
   const span = startStandaloneWebVitalSpan({
-    type: 'inp',
     name,
     transaction: routeName,
     attributes,

packages/browser-utils/src/metrics/lcp.ts

@@ -92,7 +92,6 @@ export function _sendStandaloneLcpSpan(
   }
 
   const span = startStandaloneWebVitalSpan({
-    type: 'lcp',
     name,
     transaction: routeName,
     attributes,

packages/browser-utils/src/metrics/utils.ts

@@ -7,8 +7,7 @@ import type {
   SpanTimeInput,
   StartSpanOptions,
 } from '@sentry/core';
-import { debug, getClient, getCurrentScope, spanToJSON, startInactiveSpan, withActiveSpan } from '@sentry/core';
-import { DEBUG_BUILD } from '../debug-build';
+import { getClient, getCurrentScope, spanToJSON, startInactiveSpan, withActiveSpan } from '@sentry/core';
 import { WINDOW } from '../types';
 import { onHidden } from './web-vitals/lib/onHidden';
 
@@ -56,7 +55,6 @@ export function startAndEndSpan(
 }
 
 interface StandaloneWebVitalSpanOptions {
-  type: 'lcp' | 'cls' | 'inp';
   name: string;
   transaction?: string;
   attributes: SpanAttributes;
@@ -85,7 +83,7 @@ export function startStandaloneWebVitalSpan(options: StandaloneWebVitalSpanOptio
     return;
   }
 
-  const { name, transaction, attributes: passedAttributes, startTime, type } = options;
+  const { name, transaction, attributes: passedAttributes, startTime } = options;
 
   const { release, environment, sendDefaultPii } = client.getOptions();
   // We need to get the replay, user, and activeTransaction from the current scope
@@ -127,9 +125,6 @@ export function startStandaloneWebVitalSpan(options: StandaloneWebVitalSpanOptio
     ...passedAttributes,
   };
 
-  DEBUG_BUILD &&
-    debug.log('Starting standalone web vital span', { type, name, transaction, startTime }, 'attributes:', attributes);
-
   return startInactiveSpan({
     name,
     attributes,

packages/core/src/client.ts

@@ -37,7 +37,7 @@ import { dsnToString, makeDsn } from './utils/dsn';
 import { addItemToEnvelope, createAttachmentEnvelopeItem } from './utils/envelope';
 import { getPossibleEventMessages } from './utils/eventUtils';
 import { isParameterizedString, isPlainObject, isPrimitive, isThenable } from './utils/is';
-import { logger } from './utils/logger';
+import { debug } from './utils/logger';
 import { merge } from './utils/merge';
 import { checkOrSetAlreadyCaught, uuid4 } from './utils/misc';
 import { parseSampleRate } from './utils/parseSampleRate';
@@ -154,7 +154,7 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
     if (options.dsn) {
       this._dsn = makeDsn(options.dsn);
     } else {
-      DEBUG_BUILD && logger.warn('No DSN provided, client will not send events.');
+      DEBUG_BUILD && debug.warn('No DSN provided, client will not send events.');
     }
 
     if (this._dsn) {
@@ -182,7 +182,7 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
 
     // ensure we haven't captured this very object before
     if (checkOrSetAlreadyCaught(exception)) {
-      DEBUG_BUILD && logger.log(ALREADY_SEEN_ERROR);
+      DEBUG_BUILD && debug.log(ALREADY_SEEN_ERROR);
       return eventId;
     }
 
@@ -237,7 +237,7 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
 
     // ensure we haven't captured this very object before
     if (hint?.originalException && checkOrSetAlreadyCaught(hint.originalException)) {
-      DEBUG_BUILD && logger.log(ALREADY_SEEN_ERROR);
+      DEBUG_BUILD && debug.log(ALREADY_SEEN_ERROR);
       return eventId;
     }
 
@@ -429,15 +429,15 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
     if ('aggregates' in session) {
       const sessionAttrs = session.attrs || {};
       if (!sessionAttrs.release && !clientReleaseOption) {
-        DEBUG_BUILD && logger.warn(MISSING_RELEASE_FOR_SESSION_ERROR);
+        DEBUG_BUILD && debug.warn(MISSING_RELEASE_FOR_SESSION_ERROR);
         return;
       }
       sessionAttrs.release = sessionAttrs.release || clientReleaseOption;
       sessionAttrs.environment = sessionAttrs.environment || clientEnvironmentOption;
       session.attrs = sessionAttrs;
     } else {
       if (!session.release && !clientReleaseOption) {
-        DEBUG_BUILD && logger.warn(MISSING_RELEASE_FOR_SESSION_ERROR);
+        DEBUG_BUILD && debug.warn(MISSING_RELEASE_FOR_SESSION_ERROR);
         return;
       }
       session.release = session.release || clientReleaseOption;
@@ -465,7 +465,7 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
       // would be `Partial<Record<SentryRequestType, Partial<Record<Outcome, number>>>>`
       // With typescript 4.1 we could even use template literal types
       const key = `${reason}:${category}`;
-      DEBUG_BUILD && logger.log(`Recording outcome: "${key}"${count > 1 ? ` (${count} times)` : ''}`);
+      DEBUG_BUILD && debug.log(`Recording outcome: "${key}"${count > 1 ? ` (${count} times)` : ''}`);
       this._outcomes[key] = (this._outcomes[key] || 0) + count;
     }
   }
@@ -877,12 +877,12 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
 
     if (this._isEnabled() && this._transport) {
       return this._transport.send(envelope).then(null, reason => {
-        DEBUG_BUILD && logger.error('Error while sending envelope:', reason);
+        DEBUG_BUILD && debug.error('Error while sending envelope:', reason);
         return reason;
       });
     }
 
-    DEBUG_BUILD && logger.error('Transport disabled');
+    DEBUG_BUILD && debug.error('Transport disabled');
 
     return resolvedSyncPromise({});
   }
@@ -1032,7 +1032,7 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
     isolationScope = getIsolationScope(),
   ): PromiseLike<string | undefined> {
     if (DEBUG_BUILD && isErrorEvent(event)) {
-      logger.log(`Captured error event \`${getPossibleEventMessages(event)[0] || '<unknown>'}\``);
+      debug.log(`Captured error event \`${getPossibleEventMessages(event)[0] || '<unknown>'}\``);
     }
 
     return this._processEvent(event, hint, currentScope, isolationScope).then(
@@ -1042,11 +1042,11 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
       reason => {
         if (DEBUG_BUILD) {
           if (_isDoNotSendEventError(reason)) {
-            logger.log(reason.message);
+            debug.log(reason.message);
           } else if (_isInternalError(reason)) {
-            logger.warn(reason.message);
+            debug.warn(reason.message);
           } else {
-            logger.warn(reason);
+            debug.warn(reason);
           }
         }
         return undefined;
@@ -1207,22 +1207,22 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
    * Sends client reports as an envelope.
    */
   protected _flushOutcomes(): void {
-    DEBUG_BUILD && logger.log('Flushing outcomes...');
+    DEBUG_BUILD && debug.log('Flushing outcomes...');
 
     const outcomes = this._clearOutcomes();
 
     if (outcomes.length === 0) {
-      DEBUG_BUILD && logger.log('No outcomes to send');
+      DEBUG_BUILD && debug.log('No outcomes to send');
       return;
     }
 
     // This is really the only place where we want to check for a DSN and only send outcomes then
     if (!this._dsn) {
-      DEBUG_BUILD && logger.log('No dsn provided, will not send outcomes');
+      DEBUG_BUILD && debug.log('No dsn provided, will not send outcomes');
       return;
     }
 
-    DEBUG_BUILD && logger.log('Sending outcomes:', outcomes);
+    DEBUG_BUILD && debug.log('Sending outcomes:', outcomes);
 
     const envelope = createClientReportEnvelope(outcomes, this._options.tunnel && dsnToString(this._dsn));