fix division by 0 error

Author: betegon

packages/core/src/integrations/mcp-server/attributeExtraction.ts

@@ -72,69 +72,81 @@ export function getNotificationAttributes(
   method: string,
   params: Record<string, unknown>,
 ): Record<string, string | number> {
-  const attributes: Record<string, string | number> = {};
-
   switch (method) {
     case 'notifications/cancelled':
-      if (params?.requestId) {
-        attributes['mcp.cancelled.request_id'] = String(params.requestId);
-      }
-      if (params?.reason) {
-        attributes['mcp.cancelled.reason'] = String(params.reason);
-      }
-      break;
-
+      return getCancelledAttributes(params);
     case 'notifications/message':
-      if (params?.level) {
-        attributes[MCP_LOGGING_LEVEL_ATTRIBUTE] = String(params.level);
-      }
-      if (params?.logger) {
-        attributes[MCP_LOGGING_LOGGER_ATTRIBUTE] = String(params.logger);
-      }
-      if (params?.data !== undefined) {
-        attributes[MCP_LOGGING_DATA_TYPE_ATTRIBUTE] = typeof params.data;
-        if (typeof params.data === 'string') {
-          attributes[MCP_LOGGING_MESSAGE_ATTRIBUTE] = params.data;
-        } else {
-          attributes[MCP_LOGGING_MESSAGE_ATTRIBUTE] = JSON.stringify(params.data);
-        }
-      }
-      break;
-
+      return getMessageAttributes(params);
     case 'notifications/progress':
-      if (params?.progressToken) {
-        attributes['mcp.progress.token'] = String(params.progressToken);
-      }
-      if (typeof params?.progress === 'number') {
-        attributes['mcp.progress.current'] = params.progress;
-      }
-      if (typeof params?.total === 'number') {
-        attributes['mcp.progress.total'] = params.total;
-        if (typeof params?.progress === 'number') {
-          attributes['mcp.progress.percentage'] = (params.progress / params.total) * 100;
-        }
-      }
-      if (params?.message) {
-        attributes['mcp.progress.message'] = String(params.message);
-      }
-      break;
-
+      return getProgressAttributes(params);
     case 'notifications/resources/updated':
-      if (params?.uri) {
-        attributes[MCP_RESOURCE_URI_ATTRIBUTE] = String(params.uri);
-        const urlObject = parseStringToURLObject(String(params.uri));
-        if (urlObject && !isURLObjectRelative(urlObject)) {
-          attributes['mcp.resource.protocol'] = urlObject.protocol.replace(':', '');
-        }
-      }
-      break;
-
+      return getResourcesUpdatedAttributes(params);
     case 'notifications/initialized':
-      attributes['mcp.lifecycle.phase'] = 'initialization_complete';
-      attributes['mcp.protocol.ready'] = 1;
-      break;
+      return { 'mcp.lifecycle.phase': 'initialization_complete', 'mcp.protocol.ready': 1 };
+    default:
+      return {};
   }
+}
 
+function getCancelledAttributes(params: Record<string, unknown>): Record<string, string | number> {
+  const attributes: Record<string, string | number> = {};
+  if (params?.requestId) {
+    attributes['mcp.cancelled.request_id'] = String(params.requestId);
+  }
+  if (params?.reason) {
+    attributes['mcp.cancelled.reason'] = String(params.reason);
+  }
+  return attributes;
+}
+
+function getMessageAttributes(params: Record<string, unknown>): Record<string, string | number> {
+  const attributes: Record<string, string | number> = {};
+  if (params?.level) {
+    attributes[MCP_LOGGING_LEVEL_ATTRIBUTE] = String(params.level);
+  }
+  if (params?.logger) {
+    attributes[MCP_LOGGING_LOGGER_ATTRIBUTE] = String(params.logger);
+  }
+  if (params?.data !== undefined) {
+    attributes[MCP_LOGGING_DATA_TYPE_ATTRIBUTE] = typeof params.data;
+    if (typeof params.data === 'string') {
+      attributes[MCP_LOGGING_MESSAGE_ATTRIBUTE] = params.data;
+    } else {
+      attributes[MCP_LOGGING_MESSAGE_ATTRIBUTE] = JSON.stringify(params.data);
+    }
+  }
+  return attributes;
+}
+
+function getProgressAttributes(params: Record<string, unknown>): Record<string, string | number> {
+  const attributes: Record<string, string | number> = {};
+  if (params?.progressToken) {
+    attributes['mcp.progress.token'] = String(params.progressToken);
+  }
+  if (typeof params?.progress === 'number') {
+    attributes['mcp.progress.current'] = params.progress;
+  }
+  if (typeof params?.total === 'number') {
+    attributes['mcp.progress.total'] = params.total;
+    if (typeof params?.progress === 'number') {
+      attributes['mcp.progress.percentage'] = params.total ? (params.progress / params.total) * 100 : 0;
+    }
+  }
+  if (params?.message) {
+    attributes['mcp.progress.message'] = String(params.message);
+  }
+  return attributes;
+}
+
+function getResourcesUpdatedAttributes(params: Record<string, unknown>): Record<string, string | number> {
+  const attributes: Record<string, string | number> = {};
+  if (params?.uri) {
+    attributes[MCP_RESOURCE_URI_ATTRIBUTE] = String(params.uri);
+    const urlObject = parseStringToURLObject(String(params.uri));
+    if (urlObject && !isURLObjectRelative(urlObject)) {
+      attributes['mcp.resource.protocol'] = urlObject.protocol.replace(':', '');
+    }
+  }
   return attributes;
 }