wip: vite config

Author: chargome

packages/react-router/rollup.npm.config.mjs

@@ -5,7 +5,7 @@ export default [
     makeBaseNPMConfig({
       entrypoints: ['src/index.server.ts', 'src/index.client.ts'],
       packageSpecificConfig: {
-        external: ['react-router', 'react-router-dom', 'react', 'react/jsx-runtime'],
+        external: ['react-router', 'react-router-dom', 'react', 'react/jsx-runtime', 'vite'],
         output: {
           // make it so Rollup calms down about the fact that we're combining default and named exports
           exports: 'named',

packages/react-router/src/index.server.ts

@@ -1 +1,2 @@
 export * from './server';
+export * from './vite';

packages/react-router/src/vite/makeSentryVitePlugin.ts

@@ -1,12 +1,12 @@
 import { consoleSandbox } from '@sentry/core';
 import { sentryVitePlugin } from '@sentry/vite-plugin';
-import type { Plugin, UserConfig } from 'vite';
+import { loadConfigFromFile, type Plugin, type UserConfig } from 'vite';
 import type { SentryReactRouterPluginOptions } from './types';
 
 /**
  * Creates sentry's vite plugins
  */
-export function makeSentryVitePlugins(options: SentryReactRouterPluginOptions, viteConfig: UserConfig): Plugin[] {
+export async function makeSentryVitePlugins(options: SentryReactRouterPluginOptions): Promise<Plugin[]> {
   const {
     debug,
     sourceMapsUploadOptions,
@@ -19,11 +19,24 @@ export function makeSentryVitePlugins(options: SentryReactRouterPluginOptions, v
 
   let updatedFilesToDeleteAfterUpload: string[] | undefined = undefined;
 
+  let loadedConfig: { path: string; config: UserConfig; dependencies: string[] } | null = null;
+
+  try {
+    loadedConfig = await loadConfigFromFile({ mode: 'production', command: 'build' });
+  } catch (error) {
+    if (debug) {
+      consoleSandbox(() => {
+        // eslint-disable-next-line no-console
+        console.log('[Sentry] could not load Vite config during build');
+      });
+    }
+  }
+
   if (
     typeof sourceMapsUploadOptions?.filesToDeleteAfterUpload === 'undefined' &&
     typeof unstable_sentryVitePluginOptions?.sourcemaps?.filesToDeleteAfterUpload === 'undefined' &&
     // Only if source maps were previously not set, we update the "filesToDeleteAfterUpload" (as we override the setting with "hidden")
-    typeof viteConfig.build?.sourcemap === 'undefined'
+    typeof loadedConfig?.config.build?.sourcemap === 'undefined'
   ) {
     // For .output, .vercel, .netlify etc.
     updatedFilesToDeleteAfterUpload = ['.*/**/*.map'];
@@ -58,6 +71,7 @@ export function makeSentryVitePlugins(options: SentryReactRouterPluginOptions, v
           metaFramework: 'react-router',
         },
       },
+
       ...unstable_sentryVitePluginOptions,
     }),
   ];

packages/react-router/src/vite/plugin.ts

@@ -1,4 +1,5 @@
-import type { Plugin, UserConfig } from 'vite';
+import type { ConfigEnv } from 'vite';
+import { type Plugin } from 'vite';
 import { makeSentryVitePlugins } from './makeSentryVitePlugin';
 import { makeEnableSourceMapsVitePlugins } from './sourceMaps';
 import type { SentryReactRouterPluginOptions } from './types';
@@ -10,13 +11,18 @@ import type { SentryReactRouterPluginOptions } from './types';
  * @param viteConfig - The Vite user config object
  * @returns An array of Vite plugins
  */
-export function sentryReactRouter(options: SentryReactRouterPluginOptions = {}, viteConfig: UserConfig): Plugin[] {
+export async function sentryReactRouter(
+  options: SentryReactRouterPluginOptions = {},
+  config: ConfigEnv,
+): Promise<Plugin[]> {
   const plugins: Plugin[] = [];
 
   if (process.env.NODE_ENV !== 'development') {
     if (options.sourceMapsUploadOptions?.enabled ?? true) {
-      plugins.push(...makeSentryVitePlugins(options, viteConfig));
-      plugins.push(...makeEnableSourceMapsVitePlugins(options));
+      if (config.command === 'build' && config.isSsrBuild && config.mode === 'production') {
+        plugins.push(...makeEnableSourceMapsVitePlugins(options));
+        plugins.push(...(await makeSentryVitePlugins(options)));
+      }
     }
   }