feat: Avoid usage of any

This makes the lint rule error, instead of warn, and gets rid of some more any usage.
Some of that may technically be breaking because the types can be exposed, but this should be very unlikely to affect any users.

Author: mydea

packages/core/src/fetch.ts

@@ -66,9 +66,8 @@ export function instrumentFetchRequest(
   spans[span.spanContext().spanId] = span;
 
   if (shouldAttachHeaders(handlerData.fetchData.url)) {
-    const request: string | Request = handlerData.args[0];
-
-    const options: { [key: string]: unknown } = handlerData.args[1] || {};
+    const request = handlerData.args[0] as string | Request;
+    const options = (handlerData.args[1] || {}) as Record<string, unknown>;
 
     const headers = _addTracingHeadersToFetchRequest(
       request,

packages/core/src/integrations/supabase.ts

@@ -9,6 +9,7 @@ import { defineIntegration } from '../integration';
 import { SEMANTIC_ATTRIBUTE_SENTRY_OP, SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN } from '../semanticAttributes';
 import { setHttpStatus, SPAN_STATUS_ERROR, SPAN_STATUS_OK, startSpan } from '../tracing';
 import type { IntegrationFn } from '../types-hoist/integration';
+import type { SpanAttributes } from '../types-hoist/span';
 import { isPlainObject } from '../utils/is';
 import { debug } from '../utils/logger';
 
@@ -64,7 +65,8 @@ export const FILTER_MAPPINGS = {
   not: 'not',
 };
 
-export const DB_OPERATIONS_TO_INSTRUMENT = ['select', 'insert', 'upsert', 'update', 'delete'];
+export const DB_OPERATIONS_TO_INSTRUMENT = ['select', 'insert', 'upsert', 'update', 'delete'] as const;
+type DBOperation = (typeof DB_OPERATIONS_TO_INSTRUMENT)[number];
 
 type AuthOperationFn = (...args: unknown[]) => Promise<unknown>;
 type AuthOperationName = (typeof AUTH_OPERATIONS_TO_INSTRUMENT)[number];
@@ -86,7 +88,7 @@ export interface PostgRESTFilterBuilder {
   headers: Record<string, string>;
   url: URL;
   schema: string;
-  body: any;
+  body: unknown;
 }
 
 export interface SupabaseResponse {
@@ -122,7 +124,7 @@ export interface SupabaseClientConstructor {
 export interface PostgRESTProtoThenable {
   then: <T>(
     onfulfilled?: ((value: T) => T | PromiseLike<T>) | null,
-    onrejected?: ((reason: any) => T | PromiseLike<T>) | null,
+    onrejected?: ((reason: unknown) => T | PromiseLike<T>) | null,
   ) => Promise<T>;
 }
 
@@ -152,7 +154,7 @@ function isInstrumented<T>(fn: T): boolean | undefined {
  * @param headers - The request headers
  * @returns The database operation type ('select', 'insert', 'upsert', 'update', or 'delete')
  */
-export function extractOperation(method: string, headers: Record<string, string> = {}): string {
+export function extractOperation(method: string, headers: Record<string, string> = {}): DBOperation | '<unknown-op>' {
   switch (method) {
     case 'GET': {
       return 'select';
@@ -333,7 +335,7 @@ function instrumentPostgRESTFilterBuilder(PostgRESTFilterBuilder: PostgRESTFilte
         const typedThis = thisArg as PostgRESTFilterBuilder;
         const operation = extractOperation(typedThis.method, typedThis.headers);
 
-        if (!operations.includes(operation)) {
+        if (!operations.includes(operation as DBOperation)) {
           return Reflect.apply(target, thisArg, argumentsList);
         }
 
@@ -364,7 +366,7 @@ function instrumentPostgRESTFilterBuilder(PostgRESTFilterBuilder: PostgRESTFilte
           ' ',
         )} from(${table})`;
 
-        const attributes: Record<string, any> = {
+        const attributes: SpanAttributes = {
           'db.table': table,
           'db.schema': typedThis.schema,
           'db.url': typedThis.url.origin,
@@ -380,7 +382,11 @@ function instrumentPostgRESTFilterBuilder(PostgRESTFilterBuilder: PostgRESTFilte
         }
 
         if (Object.keys(body).length) {
-          attributes['db.body'] = body;
+          try {
+            attributes['db.body'] = JSON.stringify(body);
+          } catch {
+            // could not stringify body
+          }
         }
 
         return startSpan(
@@ -465,17 +471,19 @@ function instrumentPostgRESTFilterBuilder(PostgRESTFilterBuilder: PostgRESTFilte
   markAsInstrumented((PostgRESTFilterBuilder.prototype as unknown as PostgRESTProtoThenable).then);
 }
 
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+type BuilderPrototype = Record<DBOperation, (...args: any[]) => any>;
+
 function instrumentPostgRESTQueryBuilder(PostgRESTQueryBuilder: new () => PostgRESTQueryBuilder): void {
   // We need to wrap _all_ operations despite them sharing the same `PostgRESTFilterBuilder`
   // constructor, as we don't know which method will be called first, and we don't want to miss any calls.
   for (const operation of DB_OPERATIONS_TO_INSTRUMENT) {
-    if (isInstrumented((PostgRESTQueryBuilder.prototype as Record<string, any>)[operation])) {
+    if (isInstrumented((PostgRESTQueryBuilder.prototype as BuilderPrototype)[operation])) {
       continue;
     }
 
-    type PostgRESTOperation = keyof Pick<PostgRESTQueryBuilder, 'select' | 'insert' | 'upsert' | 'update' | 'delete'>;
-    (PostgRESTQueryBuilder.prototype as Record<string, any>)[operation as PostgRESTOperation] = new Proxy(
-      (PostgRESTQueryBuilder.prototype as Record<string, any>)[operation as PostgRESTOperation],
+    (PostgRESTQueryBuilder.prototype as BuilderPrototype)[operation] = new Proxy(
+      (PostgRESTQueryBuilder.prototype as BuilderPrototype)[operation],
       {
         apply(target, thisArg, argumentsList) {
           const rv = Reflect.apply(target, thisArg, argumentsList);
@@ -490,7 +498,7 @@ function instrumentPostgRESTQueryBuilder(PostgRESTQueryBuilder: new () => PostgR
       },
     );
 
-    markAsInstrumented((PostgRESTQueryBuilder.prototype as Record<string, any>)[operation]);
+    markAsInstrumented((PostgRESTQueryBuilder.prototype as BuilderPrototype)[operation]);
   }
 }
 
@@ -517,6 +525,7 @@ const _supabaseIntegration = ((supabaseClient: unknown) => {
   };
 }) satisfies IntegrationFn;
 
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 export const supabaseIntegration = defineIntegration((options: { supabaseClient: any }) => {
   return _supabaseIntegration(options.supabaseClient);
 }) satisfies IntegrationFn;

packages/core/src/profiling.ts

@@ -1,11 +1,12 @@
+import type { Client } from './client';
 import { getClient } from './currentScopes';
 import { DEBUG_BUILD } from './debug-build';
 import type { Profiler, ProfilingIntegration } from './types-hoist/profiling';
 import { debug } from './utils/logger';
 
 function isProfilingIntegrationWithProfiler(
-  integration: ProfilingIntegration<any> | undefined,
-): integration is ProfilingIntegration<any> {
+  integration: ProfilingIntegration<Client> | undefined,
+): integration is ProfilingIntegration<Client> {
   return (
     !!integration &&
     typeof integration['_profiler'] !== 'undefined' &&
@@ -25,7 +26,7 @@ function startProfiler(): void {
     return;
   }
 
-  const integration = client.getIntegrationByName<ProfilingIntegration<any>>('ProfilingIntegration');
+  const integration = client.getIntegrationByName<ProfilingIntegration<Client>>('ProfilingIntegration');
 
   if (!integration) {
     DEBUG_BUILD && debug.warn('ProfilingIntegration is not available');
@@ -51,7 +52,7 @@ function stopProfiler(): void {
     return;
   }
 
-  const integration = client.getIntegrationByName<ProfilingIntegration<any>>('ProfilingIntegration');
+  const integration = client.getIntegrationByName<ProfilingIntegration<Client>>('ProfilingIntegration');
   if (!integration) {
     DEBUG_BUILD && debug.warn('ProfilingIntegration is not available');
     return;

packages/core/src/types-hoist/breadcrumb.ts

@@ -52,7 +52,10 @@ export interface Breadcrumb {
    *
    * @summary Arbitrary data associated with this breadcrumb.
    */
-  data?: { [key: string]: any };
+  // Note: we cannot use Record<string, unknown> here because it's not compatible with interface data types
+  // See: https://github.com/microsoft/TypeScript/issues/15300
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  data?: Record<string, any>;
 
   /**
    * The format is a numeric (integer or float) value representing
@@ -70,6 +73,9 @@ export interface Breadcrumb {
 
 /** JSDoc */
 export interface BreadcrumbHint {
+  // Note: we cannot use unknown here because it's not compatible with interface data types
+  // See: https://github.com/microsoft/TypeScript/issues/15300
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   [key: string]: any;
 }
 
@@ -90,7 +96,7 @@ export interface XhrBreadcrumbData {
 }
 
 export interface FetchBreadcrumbHint {
-  input: any[];
+  input: unknown[];
   data?: unknown;
   response?: unknown;
   startTimestamp: number;

packages/core/src/types-hoist/context.ts

@@ -1,7 +1,7 @@
 import type { FeatureFlag } from '../utils/featureFlags';
 import type { SpanLinkJSON } from './link';
 import type { Primitive } from './misc';
-import type { SpanOrigin } from './span';
+import type { SpanAttributes, SpanOrigin } from './span';
 
 export type Context = Record<string, unknown>;
 
@@ -99,7 +99,7 @@ export interface ResponseContext extends Record<string, unknown> {
 }
 
 export interface TraceContext extends Record<string, unknown> {
-  data?: { [key: string]: any };
+  data?: SpanAttributes;
   op?: string;
   parent_span_id?: string;
   span_id: string;

packages/core/src/types-hoist/error.ts

@@ -2,5 +2,5 @@
  * Just an Error object with arbitrary attributes attached to it.
  */
 export interface ExtendedError extends Error {
-  [key: string]: any;
+  [key: string]: unknown;
 }

packages/core/src/types-hoist/event.ts

@@ -83,6 +83,6 @@ export interface EventHint {
   syntheticException?: Error | null;
   originalException?: unknown;
   attachments?: Attachment[];
-  data?: any;
+  data?: unknown;
   integrations?: string[];
 }

packages/core/src/types-hoist/feedback/config.ts

@@ -1,4 +1,5 @@
 import type { Primitive } from '../misc';
+import type { User } from '../user';
 import type { FeedbackFormData } from './form';
 import type { FeedbackTheme } from './theme';
 
@@ -53,8 +54,8 @@ export interface FeedbackGeneralConfiguration {
    * The value of the email/name keys represent the properties of your user context.
    */
   useSentryUser: {
-    email: string;
-    name: string;
+    email: keyof User;
+    name: keyof User;
   };
 
   /**

packages/core/src/types-hoist/instrument.ts

@@ -47,7 +47,7 @@ interface SentryFetchData {
 }
 
 export interface HandlerDataFetch {
-  args: any[];
+  args: unknown[];
   fetchData: SentryFetchData; // This data is among other things dumped directly onto the fetch breadcrumb data
   startTimestamp: number;
   endTimestamp?: number;
@@ -74,7 +74,7 @@ export interface HandlerDataDom {
 
 export interface HandlerDataConsole {
   level: ConsoleLevel;
-  args: any[];
+  args: unknown[];
 }
 
 export interface HandlerDataHistory {

packages/core/src/types-hoist/integration.ts

@@ -47,4 +47,5 @@ export interface Integration {
  * An integration in function form.
  * This is expected to return an integration.
  */
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 export type IntegrationFn<IntegrationType = Integration> = (...rest: any[]) => IntegrationType;