User Feedback integration not working with scopes

[sheldhur]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Self-hosted/on-premise

Which SDK are you using?

@sentry/browser

SDK Version

8.34.0

Framework Version

No response

Link to Sentry event

No response

Reproduction Example/SDK Setup

const integrations = getDefaultIntegrations({}).filter((defaultIntegration) => {
  return !['BrowserApiErrors', 'Breadcrumbs', 'GlobalHandlers'].includes(
    defaultIntegration.name,
  );
});

const feedback = feedbackIntegration({
  autoInject: false,
  colorScheme: 'light',
  showScreenshot: true,
  onSubmitError: (error: Error) => {
    console.log('onSubmitError', error);
  },
});

const client = new BrowserClient({
  dsn: import.meta.env.VITE_SCENTRY_DSN,
  transport: makeFetchTransport,
  stackParser: defaultStackParser,
  integrations: [...integrations, feedback],
});

export const scope = new Scope();
scope.setClient(client);

client.init();

Steps to Reproduce

console.log(getFeedback()) // return undefined
console.log(scope.getClient()?.getIntegrationByName('Feedback')) // return feedbackIntegration

captureFeedback(
    {
      name: 'Jane Doe', 
      email: 'email@example.org',
      message: 'This is an example feedback',
    },
    {},
    scope,
); // sends feedback

const form = await feedback.createForm();
form.appendToDom();
form.open();

Try to submit feedback form

Expected Result

1. I can bind feedback to my scope
2. getFeedback() return feedbackIntegration with my scope

Actual Result

Catch the error when submit form

onSubmitError Error: No client setup, cannot send feedback.

setCurrentClient(client);
console.log(getFeedback()) // return feedbackIntegration

After that feedback form is submits without errors

[mydea]

Hey there,

first of all, the way you try to filter default integrations does not work. This will still add the default integrations you are trying to filter. You need to follow docs as here to filter them out: https://docs.sentry.io/platforms/javascript/configuration/integrations/#removing-a-default-integration

Regarding your comment, that is correct indeed, user feedback as of now does not work with custom scopes out of the box. User feedback is a global integration that uses the globally set up client, as of now.

You can manually set up a feedback form and use the following API to send feedback for a specific scope:

Sentry.captureFeedback(..., {}, scope);

[sheldhur]

You can manually set up a feedback form and use the following API to send feedback for a specific scope:

I know

the way you try to filter default integrations does not work

But that example from documentation 😂 https://docs.sentry.io/platforms/javascript/best-practices/shared-environments/