[RR7] Source maps not uploading

[namoscato]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/browser

SDK Version

9.3.0

Framework Version

React Router 7.2.0

Link to Sentry event

https://amoscato.sentry.io/issues/6356032590/events/ee0d4a3bb3f947d88a10ac9d0b154771/

Reproduction Example/SDK Setup

I started integrating Sentry into a React Router v7 SPA project deployed via Vercel in namoscato/tiny-truths#22

Steps to Reproduce

Following React Router Framework guide:

1. install @sentry/react-router package
2. configure client-side setup
3. update vite.config.ts for source maps upload
4. include the sentryOnBuildEnd hook in react-router.config.ts
5. configure SENTRY_AUTH_TOKEN Vercel environment variable

Expected Result

Source maps upload to Sentry within Vercel build

Actual Result

Debug IDs seem to be getting injected as expected:

[15:27:26.967] > Searching /vercel/path0/build
[15:27:26.974] > Found 21 files
[15:27:26.976] > Analyzing 21 sources
[15:27:26.983] > Injecting debug ids
[15:27:27.046] 
[15:27:27.047] Source Map Debug ID Injection Report
[15:27:27.047]   Modified: The following source files have been modified to have debug ids
[15:27:27.048]     4ae7e42d-0da7-5163-9cc2-62e6054d7b09 - /vercel/path0/build/client/assets/EpisodeContent-B20qnC5P.js
[15:27:27.048]     8b337345-34bb-5caa-a5af-bd7e8db58de4 - /vercel/path0/build/client/assets/chunk-HA7DTUK3-BMcUp_uF.js
[15:27:27.048]     2ff537df-0dc6-57a9-9578-ffb05a1be291 - /vercel/path0/build/client/assets/createRouteMeta-BMZW6XCQ.js
[15:27:27.048]     029d6be6-ca39-5c90-a808-6da1ef4ae503 - /vercel/path0/build/client/assets/entry.client-Dd4QKhbr.js
[15:27:27.049]     3911e7ac-3df6-5c59-aa96-068b6c31d0c4 - /vercel/path0/build/client/assets/episode-5dlANhrG.js
[15:27:27.049]     eaa123d3-b9fa-5ea0-b74d-cf8a1934f860 - /vercel/path0/build/client/assets/episodes-CxWgLta1.js
[15:27:27.049]     9aa76017-cdce-5efb-935d-2414efa21d9f - /vercel/path0/build/client/assets/exports-D5jgihaW.js
[15:27:27.049]     c56394a4-d59b-55cb-94b1-1ff80212950a - /vercel/path0/build/client/assets/home-lHlyT5e2.js
[15:27:27.050]     c765a802-675a-5456-adb1-c425f0876f63 - /vercel/path0/build/client/assets/manifest-6946edfd.js
[15:27:27.050]     6e063b5b-4766-5f96-8380-2f9e1014f774 - /vercel/path0/build/client/assets/root-B0Wlntzn.js
[15:27:27.050]     0fd95fd0-01a2-5752-a83d-8b5f8cd8345d - /vercel/path0/build/client/assets/with-props-Cv3de-lK.js
[15:27:27.050]   Modified: The following sourcemap files have been modified to have debug ids
[15:27:27.050]     4ae7e42d-0da7-5163-9cc2-62e6054d7b09 - /vercel/path0/build/client/assets/EpisodeContent-B20qnC5P.js.map
[15:27:27.051]     8b337345-34bb-5caa-a5af-bd7e8db58de4 - /vercel/path0/build/client/assets/chunk-HA7DTUK3-BMcUp_uF.js.map
[15:27:27.051]     2ff537df-0dc6-57a9-9578-ffb05a1be291 - /vercel/path0/build/client/assets/createRouteMeta-BMZW6XCQ.js.map
[15:27:27.051]     029d6be6-ca39-5c90-a808-6da1ef4ae503 - /vercel/path0/build/client/assets/entry.client-Dd4QKhbr.js.map
[15:27:27.051]     3911e7ac-3df6-5c59-aa96-068b6c31d0c4 - /vercel/path0/build/client/assets/episode-5dlANhrG.js.map
[15:27:27.052]     eaa123d3-b9fa-5ea0-b74d-cf8a1934f860 - /vercel/path0/build/client/assets/episodes-CxWgLta1.js.map
[15:27:27.052]     9aa76017-cdce-5efb-935d-2414efa21d9f - /vercel/path0/build/client/assets/exports-D5jgihaW.js.map
[15:27:27.052]     c56394a4-d59b-55cb-94b1-1ff80212950a - /vercel/path0/build/client/assets/home-lHlyT5e2.js.map
[15:27:27.052]     6e063b5b-4766-5f96-8380-2f9e1014f774 - /vercel/path0/build/client/assets/root-B0Wlntzn.js.map
[15:27:27.053]     0fd95fd0-01a2-5752-a83d-8b5f8cd8345d - /vercel/path0/build/client/assets/with-props-Cv3de-lK.js.map
[15:27:27.053] Build Completed in /vercel/output [10s]

where I believe the last line is coming from Vercel's build (outside the context of the Vite plugin).

However, the source maps do not seem to be getting uploaded per this subsequent step.

Through some debugging, I verified:

• org and project are set to expected values
• sourceMapsUploadOptions: { enabled: true }
• reactRouterConfig.buildDirectory: '/vercel/path0/build'
• source maps are not deleted during the build; therefore, it doesn't seem like the final updatedFilesToDeleteAfterUpload step is getting invoked either

I didn't realize this SDK was so new, so perhaps this is not expected to work yet. But thanks in advance for the help!

/cc @chargome

[AbhiPrasad]

@namoscato you might have to throw an await on the sentryOnBuildEnd call.

There's a docs fix for this, we need to merge it in: getsentry/sentry-docs#12889

[namoscato]

Oh yeah, that was subtle but indeed the issue 🤦🏻

Thanks, @AbhiPrasad!

[AbhiPrasad]

@namoscato sorry for the trouble, we'll get that docs fix merged asap!