feat(feedback): Add reason argument to onFormClose callback
#12811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan953
force-pushed
the
ryan953/73901-add-reason-to-onFormClose
branch
from
3590265 to
d916488
Compare
size-limit report 📦
|
ryan953
changed the title
reason argument to onFormClose callbackreason argument to onFormClose callback
c298lee
reviewed
Jul 9, 2024
| }, | ||
| }), | ||
| ), | ||
| ...makeBundleConfigVariants( |
There was a problem hiding this comment.
oops, this isn't needed. I think it's leftover when i was playing with bundle-size measurements. This isn't a real bundle that we should be shipping.
c298lee
approved these changes
Jul 9, 2024
ryan953
commented
Jul 10, 2024
| import { FAKE_FUNCTION } from './common'; | ||
|
|
||
| const FEEDBACK_INTEGRATION_METHODS = ['attachTo', 'createWidget', 'remove'] as const; | ||
| const FEEDBACK_INTEGRATION_METHODS = ['attachTo', 'createForm', 'createWidget', 'remove'] as const; |
There was a problem hiding this comment.
This shim was missing before, nice to get it in
|
@ryan953 just going through our PRs for triage party: Do you want to revisit this PR or are you fine with closing it? No pressure, just trying to clean up some things :) |
|
@Lms24 oh, we should re-test and merge this. i think it's helpful |
|
err, but lets close for now because of the conflicts. i'm not getting to it today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
reasonargument toonFormCloseso folks can tell the difference between users who've clicked the intentional "Cancel" button, vs. clicks outside of the feedback form which might've unintentionally hidden the form.Relates to #12812