ref(utils): Move flushSafelyWithTimeout to utils
#14061
Conversation
|
I would not do this. This function is too dumb to be put in a utility. Extending the API of utils is not entirely free - it may seem like it but it may break people in some edge cases. |
|
@andreiborza and me were talking about this here: https://github.com/getsentry/sentry-javascript/pull/13986/files#r1801204658 But regarding this can be used by users if we export this, I think it's fine to duplicate it. What do you think @andreiborza ? |
There was a problem hiding this comment.
No strong opinion but I think it's fine to extract this to utils, given we do use it in various SDKs and this is 1:1 duplicated code. Furthermore, we don't make any guarantees w.r.t breaking changes in utils, so technically we're good if we were to introduce any API breakage. @lforst do you have concrete concerns about implicit breakage? (i.e. when users don't actively depend on it)
|
Will close this as |
3 participants
No description provided.