Skip to content

debug(replay): Remove noisy log that is causing event buffer overflow as well #14069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024
Merged

debug(replay): Remove noisy log that is causing event buffer overflow as well #14069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/replay-internal/src/eventBuffer/EventBufferCompressionWorker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,6 @@ export class EventBufferCompressionWorker implements EventBuffer {
this._totalSize += data.length;

if (this._totalSize > REPLAY_MAX_EVENT_BUFFER_SIZE) {
DEBUG_BUILD &&
logger.info(
`Cannot add new event with raw size of ${data.length} to existing buffer of size ${
this._totalSize - data.length
}`,
);
return Promise.reject(new EventBufferSizeExceededError());
}

Expand Down
4 changes: 3 additions & 1 deletion packages/replay-internal/src/replay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,9 @@ export class ReplayContainer implements ReplayContainerInterface {
this._isEnabled = false;

try {
DEBUG_BUILD && logger.info(`Stopping Replay${reason ? ` triggered by ${reason}` : ''}`);
DEBUG_BUILD &&
reason !== 'addEventSizeExceeded' &&
logger.info(`Stopping Replay${reason ? ` triggered by ${reason}` : ''}`);

resetReplayIdOnDynamicSamplingContext();

Expand Down
Loading