From ca14976d48b698fb246d9b74c6798d8c1a0670d5 Mon Sep 17 00:00:00 2001 From: Andrei Borza Date: Mon, 4 Nov 2024 10:56:52 +0100 Subject: [PATCH 1/2] Run E2E tests for node-profiling --- .github/workflows/build.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c17b81246e79..0f3d90273ad1 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1225,14 +1225,14 @@ jobs: # Dependabot specifically also has access to secrets # We need to add the `always()` check here because the previous step has this as well :( # See: https://github.com/actions/runner/issues/2205 - if: +# if: # Only run profiling e2e tests if profiling node bindings have changed - always() && needs.job_e2e_prepare.result == 'success' && - (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) && - ( - (needs.job_get_metadata.outputs.changed_profiling_node == 'true') || - (needs.job_get_metadata.outputs.is_release == 'true') - ) +# always() && needs.job_e2e_prepare.result == 'success' && +# (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) && +# ( +# (needs.job_get_metadata.outputs.changed_profiling_node == 'true') || +# (needs.job_get_metadata.outputs.is_release == 'true') +# ) needs: [job_get_metadata, job_build, job_e2e_prepare] runs-on: ubuntu-20.04 timeout-minutes: 15 From 8dc7464fec68638828a0f01cef6e942bc9107cf3 Mon Sep 17 00:00:00 2001 From: Andrei Borza Date: Mon, 4 Nov 2024 11:18:09 +0100 Subject: [PATCH 2/2] . --- .github/workflows/build.yml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 0f3d90273ad1..0fe73025cf86 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1225,14 +1225,15 @@ jobs: # Dependabot specifically also has access to secrets # We need to add the `always()` check here because the previous step has this as well :( # See: https://github.com/actions/runner/issues/2205 -# if: + if: # Only run profiling e2e tests if profiling node bindings have changed -# always() && needs.job_e2e_prepare.result == 'success' && -# (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) && -# ( -# (needs.job_get_metadata.outputs.changed_profiling_node == 'true') || -# (needs.job_get_metadata.outputs.is_release == 'true') -# ) + always() && needs.job_e2e_prepare.result == 'success' && + (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) + # && + # ( + # (needs.job_get_metadata.outputs.changed_profiling_node == 'true') || + # (needs.job_get_metadata.outputs.is_release == 'true') + # ) needs: [job_get_metadata, job_build, job_e2e_prepare] runs-on: ubuntu-20.04 timeout-minutes: 15