-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(node): Add a function to resolve entry point type #14352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| "compilerOptions": { | ||
| "lib": ["es2018"], | ||
| "lib": ["es2018", "es2020.string"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to use string.matchAll and it turns out everything in es2020.string is fully supported by all the Node versions we support.
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Can be used to:
--import[v9] Change default ofonlyIncludeInstrumentedModulesin Node SDK #14332--requireand later use ESM that instrumentation wont workThe code makes a point of returning
unknownrather than giving false positives. For example, it returnsunknownin these cases:--import/--require