From 08856f9960e20013daf867a550cd126c6fe9ff8c Mon Sep 17 00:00:00 2001 From: David Turissini Date: Tue, 14 Jan 2025 16:04:58 -0800 Subject: [PATCH 1/2] removing unused file --- .../test/server/rewriteFramesIntegration.ts | 86 ------------------- 1 file changed, 86 deletions(-) delete mode 100644 packages/sveltekit/test/server/rewriteFramesIntegration.ts diff --git a/packages/sveltekit/test/server/rewriteFramesIntegration.ts b/packages/sveltekit/test/server/rewriteFramesIntegration.ts deleted file mode 100644 index 3dfd5d3e460e..000000000000 --- a/packages/sveltekit/test/server/rewriteFramesIntegration.ts +++ /dev/null @@ -1,86 +0,0 @@ -import { rewriteFramesIntegration } from '@sentry/browser'; -import { basename } from '@sentry/core'; -import type { Event, StackFrame } from '@sentry/core'; - -import { rewriteFramesIteratee } from '../../src/server/rewriteFramesIntegration'; -import type { GlobalWithSentryValues } from '../../src/vite/injectGlobalValues'; - -describe('rewriteFramesIteratee', () => { - it('removes the module property from the frame', () => { - const frame: StackFrame = { - filename: '/some/path/to/server/chunks/3-ab34d22f.js', - module: '3-ab34d22f.js', - }; - - const result = rewriteFramesIteratee(frame); - - expect(result).not.toHaveProperty('module'); - }); - - it('does the same filename modification as the default RewriteFrames iteratee if no output dir is available', () => { - const frame: StackFrame = { - filename: '/some/path/to/server/chunks/3-ab34d22f.js', - lineno: 1, - colno: 1, - module: '3-ab34d22f.js', - }; - - const originalRewriteFrames = rewriteFramesIntegration(); - const rewriteFrames = rewriteFramesIntegration({ iteratee: rewriteFramesIteratee }); - - const event: Event = { - exception: { - values: [ - { - stacktrace: { - frames: [frame], - }, - }, - ], - }, - }; - - const originalResult = originalRewriteFrames.processEvent?.(event, {}, {} as any); - const result = rewriteFrames.processEvent?.(event, {}, {} as any) as Event; - - expect(result.exception?.values?.[0]?.stacktrace?.frames?.[0]).toEqual({ - filename: 'app:///3-ab34d22f.js', - lineno: 1, - colno: 1, - }); - - expect(result).toStrictEqual(originalResult); - }); - - it.each([ - ['adapter-node', 'build', '/absolute/path/to/build/server/chunks/3-ab34d22f.js', 'app:///chunks/3-ab34d22f.js'], - [ - 'adapter-auto', - '.svelte-kit/output', - '/absolute/path/to/.svelte-kit/output/server/entries/pages/page.ts.js', - 'app:///entries/pages/page.ts.js', - ], - ])( - 'removes the absolut path to the server output dir, if the output dir is available (%s)', - (_, outputDir, frameFilename, modifiedFilename) => { - (globalThis as unknown as GlobalWithSentryValues).__sentry_sveltekit_output_dir = outputDir; - - const frame: StackFrame = { - filename: frameFilename, - lineno: 1, - colno: 1, - module: basename(frameFilename), - }; - - const result = rewriteFramesIteratee({ ...frame }); - - expect(result).toStrictEqual({ - filename: modifiedFilename, - lineno: 1, - colno: 1, - }); - - delete (globalThis as unknown as GlobalWithSentryValues).__sentry_sveltekit_output_dir; - }, - ); -}); From bd083d9afea6a326da81fe54bd6ca332a57316c6 Mon Sep 17 00:00:00 2001 From: David Turissini Date: Tue, 14 Jan 2025 16:14:23 -0800 Subject: [PATCH 2/2] renaming to test file --- .../server/rewriteFramesIntegration.test.ts | 86 +++++++++++++++++++ 1 file changed, 86 insertions(+) create mode 100644 packages/sveltekit/test/server/rewriteFramesIntegration.test.ts diff --git a/packages/sveltekit/test/server/rewriteFramesIntegration.test.ts b/packages/sveltekit/test/server/rewriteFramesIntegration.test.ts new file mode 100644 index 000000000000..3dfd5d3e460e --- /dev/null +++ b/packages/sveltekit/test/server/rewriteFramesIntegration.test.ts @@ -0,0 +1,86 @@ +import { rewriteFramesIntegration } from '@sentry/browser'; +import { basename } from '@sentry/core'; +import type { Event, StackFrame } from '@sentry/core'; + +import { rewriteFramesIteratee } from '../../src/server/rewriteFramesIntegration'; +import type { GlobalWithSentryValues } from '../../src/vite/injectGlobalValues'; + +describe('rewriteFramesIteratee', () => { + it('removes the module property from the frame', () => { + const frame: StackFrame = { + filename: '/some/path/to/server/chunks/3-ab34d22f.js', + module: '3-ab34d22f.js', + }; + + const result = rewriteFramesIteratee(frame); + + expect(result).not.toHaveProperty('module'); + }); + + it('does the same filename modification as the default RewriteFrames iteratee if no output dir is available', () => { + const frame: StackFrame = { + filename: '/some/path/to/server/chunks/3-ab34d22f.js', + lineno: 1, + colno: 1, + module: '3-ab34d22f.js', + }; + + const originalRewriteFrames = rewriteFramesIntegration(); + const rewriteFrames = rewriteFramesIntegration({ iteratee: rewriteFramesIteratee }); + + const event: Event = { + exception: { + values: [ + { + stacktrace: { + frames: [frame], + }, + }, + ], + }, + }; + + const originalResult = originalRewriteFrames.processEvent?.(event, {}, {} as any); + const result = rewriteFrames.processEvent?.(event, {}, {} as any) as Event; + + expect(result.exception?.values?.[0]?.stacktrace?.frames?.[0]).toEqual({ + filename: 'app:///3-ab34d22f.js', + lineno: 1, + colno: 1, + }); + + expect(result).toStrictEqual(originalResult); + }); + + it.each([ + ['adapter-node', 'build', '/absolute/path/to/build/server/chunks/3-ab34d22f.js', 'app:///chunks/3-ab34d22f.js'], + [ + 'adapter-auto', + '.svelte-kit/output', + '/absolute/path/to/.svelte-kit/output/server/entries/pages/page.ts.js', + 'app:///entries/pages/page.ts.js', + ], + ])( + 'removes the absolut path to the server output dir, if the output dir is available (%s)', + (_, outputDir, frameFilename, modifiedFilename) => { + (globalThis as unknown as GlobalWithSentryValues).__sentry_sveltekit_output_dir = outputDir; + + const frame: StackFrame = { + filename: frameFilename, + lineno: 1, + colno: 1, + module: basename(frameFilename), + }; + + const result = rewriteFramesIteratee({ ...frame }); + + expect(result).toStrictEqual({ + filename: modifiedFilename, + lineno: 1, + colno: 1, + }); + + delete (globalThis as unknown as GlobalWithSentryValues).__sentry_sveltekit_output_dir; + }, + ); +});