Skip to content

Conversation

@Cherry
Copy link

@Cherry Cherry commented Feb 11, 2025

This resolves issues with Pinia 3 and npm throwing conflicts with @sentry/vue:

npm error Conflicting peer dependency: [email protected]
npm error node_modules/pinia
npm error   peerOptional pinia@"2.x" from @sentry/[email protected]
npm error   node_modules/@sentry/vue
npm error     dev @sentry/vue@"9.0.1" from the root project

Changelog: https://github.com/vuejs/pinia/blob/v3/packages/pinia/CHANGELOG.md

There's no real user-facing changes here and everything still seems to work from my basic testing, but please let me know if I can do anything else to help validate here.

@Cherry Cherry changed the title fix: allow pinia 3 in @sentry/vue peer deps fix(vue): allow pinia 3 in @sentry/vue peer deps Feb 12, 2025
@s1gr1d
Copy link
Member

s1gr1d commented Feb 12, 2025

Hy, thanks for wanting to contribute this! Sadly, I have to close this PR as we also got an issue regarding Pinia v3 (here) and after seeing the issue I added it right away. Just after doing this I saw that there is your PR as well.

@s1gr1d s1gr1d closed this Feb 12, 2025
@Cherry
Copy link
Author

Cherry commented Feb 12, 2025

No worries, thank you for the quick resolution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants