Skip to content

feat(opentelemetry): Add links to span options #15403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 17, 2025
Merged

feat(opentelemetry): Add links to span options #15403

merged 13 commits into from
Feb 17, 2025

Conversation

@s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Feb 13, 2025 •
edited
Loading

This PR adds the possibility to add a links array that can be passed to the span options at creation of the span.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 23.02 KB - -
@sentry/browser - with treeshaking flags 22.8 KB - -
@sentry/browser (incl. Tracing) 36.04 KB - -
@sentry/browser (incl. Tracing, Replay) 73.03 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.5 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 77.28 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 90.23 KB - -
@sentry/browser (incl. Feedback) 40.18 KB - -
@sentry/browser (incl. sendFeedback) 27.65 KB - -
@sentry/browser (incl. FeedbackAsync) 32.45 KB - -
@sentry/react 24.84 KB - -
@sentry/react (incl. Tracing) 37.92 KB - -
@sentry/vue 27.2 KB - -
@sentry/vue (incl. Tracing) 37.73 KB - -
@sentry/svelte 23.06 KB - -
CDN Bundle 24.22 KB - -
CDN Bundle (incl. Tracing) 36.06 KB - -
CDN Bundle (incl. Tracing, Replay) 70.89 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 76.06 KB - -
CDN Bundle - uncompressed 70.83 KB - -
CDN Bundle (incl. Tracing) - uncompressed 107.09 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.31 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 230.88 KB - -
@sentry/nextjs (client) 38.91 KB - -
@sentry/sveltekit (client) 36.45 KB - -
@sentry/node 127.71 KB +0.01% +6 B 🔺
@sentry/node - without tracing 98 KB +0.01% +6 B 🔺
@sentry/aws-serverless 107.42 KB +0.01% +7 B 🔺

View base workflow run

@s1gr1d s1gr1d force-pushed the sig/otel-top-level-span-links branch from 845af3d to 4372b90 Compare February 13, 2025 13:49
@s1gr1d s1gr1d requested a review from Lms24 February 13, 2025 13:49
@s1gr1d s1gr1d mentioned this pull request Feb 13, 2025
Closed
6 tasks
Base automatically changed from sig/otel-addLink to develop February 17, 2025 11:38
s1gr1d and others added 2 commits February 17, 2025 15:48
@s1gr1d
Merge branch 'develop' into sig/otel-top-level-span-links
cb4a89c 
# Conflicts:
#	dev-packages/node-integration-tests/suites/tracing/linking/test.ts
#	packages/opentelemetry/test/spanExporter.test.ts
#	packages/opentelemetry/test/trace.test.ts
@s1gr1d
Merge branch 'develop' into sig/otel-top-level-span-links
184aef1
@codecov
Copy link

codecov bot commented Feb 17, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4582 1 4581 324
View the top 1 failed test(s) by shortest run time 
OnUncaughtException integration should close process on uncaught error with no additional listeners registered
Stack Traces | 15s run time 
Error: expect.assertions(3)

Expected three assertions to be called but received one assertion call.
    at Object.<anonymous> (.../public-api/OnUncaughtException/test.ts:6:12)
    at Promise.then.completed (.../jest-circus/build/utils.js:381:26)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:316:10)
    at _callCircusTest (.../jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (.../jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:66:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:60:9)
    at run (.../jest-circus/build/run.js:25:3)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@s1gr1d s1gr1d merged commit 6363e75 into develop Feb 17, 2025
147 checks passed
@s1gr1d s1gr1d deleted the sig/otel-top-level-span-links branch February 17, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@s1gr1d @Lms24