Skip to content

test(core): Migrate to vitest #15474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 25, 2025
Merged

test(core): Migrate to vitest #15474

merged 4 commits into from
Feb 25, 2025

Conversation

@timfish
Copy link
Collaborator

@timfish timfish commented Feb 24, 2025

timfish
timfish commented Feb 24, 2025
View reviewed changes
@timfish timfish marked this pull request as ready for review February 24, 2025 15:51
@timfish timfish requested a review from Lms24 February 24, 2025 15:51
@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2025 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.06 KB +0.03% +5 B 🔺
@sentry/browser - with treeshaking flags 22.84 KB +0.02% +4 B 🔺
@sentry/browser (incl. Tracing) 36.13 KB +0.01% +2 B 🔺
@sentry/browser (incl. Tracing, Replay) 73.14 KB +0.01% +4 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.6 KB +0.01% +1 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 77.39 KB +0.01% +2 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 90.34 KB +0.01% +4 B 🔺
@sentry/browser (incl. Feedback) 40.21 KB +0.01% +4 B 🔺
@sentry/browser (incl. sendFeedback) 27.68 KB +0.02% +4 B 🔺
@sentry/browser (incl. FeedbackAsync) 32.48 KB +0.01% +3 B 🔺
@sentry/react 24.87 KB +0.02% +3 B 🔺
@sentry/react (incl. Tracing) 38.01 KB +0.01% +2 B 🔺
@sentry/vue 27.3 KB +0.02% +3 B 🔺
@sentry/vue (incl. Tracing) 37.81 KB +0.01% +3 B 🔺
@sentry/svelte 23.1 KB +0.03% +6 B 🔺
CDN Bundle 24.26 KB +0.03% +7 B 🔺
CDN Bundle (incl. Tracing) 36.15 KB +0.02% +4 B 🔺
CDN Bundle (incl. Tracing, Replay) 71 KB +0.01% +5 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 76.18 KB +0.01% +4 B 🔺
CDN Bundle - uncompressed 70.93 KB +0.03% +20 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 107.31 KB +0.02% +20 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.59 KB +0.01% +20 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 231.15 KB +0.01% +20 B 🔺
@sentry/nextjs (client) 39.17 KB +0.02% +6 B 🔺
@sentry/sveltekit (client) 36.54 KB -0.01% -1 B 🔽
@sentry/node 129.25 KB +0.01% +1 B 🔺
@sentry/node - without tracing 98.03 KB +0.01% +2 B 🔺
@sentry/aws-serverless 107.45 KB +0.01% +1 B 🔺

View base workflow run

@codecov
Copy link

codecov bot commented Feb 24, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4649 1 4648 329
View the top 1 failed test(s) by shortest run time 
sessions/initial-scope/test.ts should start a new session with navigation.
Stack Traces | 0.275s run time 
test.ts:19:11 should start a new session with navigation.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@timfish timfish requested a review from AbhiPrasad February 24, 2025 16:32
@timfish timfish changed the title test(core): Migrate jest to vitest test(core): Migrate to vitest Feb 24, 2025
Lms24
Lms24 approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see that we can now use Vitest everywhere. Thanks for tackling this, Tim!

@Lms24 Lms24 merged commit 492f9fb into develop Feb 25, 2025
148 checks passed
@Lms24 Lms24 deleted the timfish/test-vitest-core branch February 25, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Switch to vitest in @sentry/core

3 participants

@timfish @Lms24 @AbhiPrasad