ref(opentelemetry): Remove usage of parseUrl
#15954
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
lforst
reviewed
Apr 2, 2025
Contributor
lforst
left a comment
lforst
left a comment
There was a problem hiding this comment.
Love this! One of the changes looks a tiny bit sus/buggy.
| fragment: string | undefined; | ||
| hasRoute: boolean; | ||
| } { | ||
| ): [parsedUrl: ReturnType<typeof parseStringToURLObject>, httpRoute: string | undefined] { |
Contributor
There was a problem hiding this comment.
can we get the httpRoute logic out of here somehow? It seems like all we do is read the http.route attribute and return it.
|
|
||
| if (!urlPath) { | ||
| if (!parsedUrl) { | ||
| return { ...getUserUpdatedNameAndSource(name, attributes), op: opParts.join('.') }; |
Contributor
There was a problem hiding this comment.
h: If we have an httpRoute but no parsedUrl we would return the original name here. I don't know if that is desired.
Member
Author
|
Will come back to this when I get more time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #15939
parseUrlis expensive, so let's refactor to remove it. This makes the change for the opentelemetry package.Removal of
getSanitizedUrlStringandstripUrlQueryAndFragmentshould also help with performance as we no longer have the js regex to compute.