Skip to content

ref: Remove @typescript-eslint/no-empty-function eslint rule #17057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Jul 17, 2025

This is IMHO not super helpful, we constantly disable it or add a noop comment for no gain.

This is IMHO not super helpful, we constantly disable it or add a noop comment for no gain.
@mydea mydea requested review from RulaKhaled and andreiborza July 17, 2025 10:34
@mydea mydea self-assigned this Jul 17, 2025
@mydea mydea requested a review from a team as a code owner July 17, 2025 10:34
cursor[bot]

This comment was marked as outdated.

Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, also found this one weird.

@mydea mydea enabled auto-merge (squash) July 17, 2025 12:22
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.78 kB - -
@sentry/browser - with treeshaking flags 22.34 kB - -
@sentry/browser (incl. Tracing) 39.66 kB - -
@sentry/browser (incl. Tracing, Replay) 77.79 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.59 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 82.49 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 94.59 kB - -
@sentry/browser (incl. Feedback) 40.48 kB - -
@sentry/browser (incl. sendFeedback) 28.46 kB - -
@sentry/browser (incl. FeedbackAsync) 33.36 kB - -
@sentry/react 25.54 kB - -
@sentry/react (incl. Tracing) 41.62 kB - -
@sentry/vue 28.23 kB - -
@sentry/vue (incl. Tracing) 41.45 kB - -
@sentry/svelte 23.81 kB - -
CDN Bundle 25.18 kB - -
CDN Bundle (incl. Tracing) 39.42 kB - -
CDN Bundle (incl. Tracing, Replay) 75.42 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 80.89 kB - -
CDN Bundle - uncompressed 73.44 kB - -
CDN Bundle (incl. Tracing) - uncompressed 116.86 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 231 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 243.81 kB - -
@sentry/nextjs (client) 43.66 kB - -
@sentry/sveltekit (client) 40.08 kB - -
@sentry/node 168.98 kB - -
@sentry/node - without tracing 100.2 kB +0.01% +1 B 🔺
@sentry/aws-serverless 128.24 kB -0.09% -113 B 🔽

View base workflow run

@mydea mydea merged commit ad5e7c3 into develop Jul 17, 2025
169 of 170 checks passed
@mydea mydea deleted the fn/remove-no-empty-rule branch July 17, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants